Skip to content

Start delivery regardless of auto_capture_sessions #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

Start delivery regardless of auto_capture_sessions #367

merged 1 commit into from
Dec 7, 2023

Conversation

imjoehaines
Copy link
Contributor

Goal

If auto_capture_sessions is False we still want to deliver any manual sessions that may be left, so we should still start session delivery in this case

Currently session delivery only happens if auto_capture_sessions is True or notify is called:

bugsnag-python/bugsnag/client.py

Lines 205 to 206 in 563063f

# Trigger session delivery
self.session_tracker.send_sessions()

Base automatically changed from session-test-improvements to next December 7, 2023 14:15
@imjoehaines
Start delivery regardless of auto_capture_sessions
63c32d1 
If auto_capture_sessions is False we still want to deliver any manual
sessions that may be left, so we should still start session delivery in
this case
@imjoehaines imjoehaines merged commit 0326a6f into next Dec 7, 2023
@imjoehaines imjoehaines deleted the manual-sessions branch December 7, 2023 14:30
@imjoehaines imjoehaines mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjoehaines @tomlongridge