Skip to content

Remove use of deprecated pkg_resources module #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

imjoehaines
Copy link
Contributor

Goal

pkg_resources has been deprecated but we only use it to fetch bugsnag-python's version number for the notifier part of the payload. We can encode this in the source to avoid depending on this module. This also removes a couple of possible (though unlikely in practice) failure cases that would result in no version being sent

See the warning in the docs: https://setuptools.pypa.io/en/latest/pkg_resources.html

@imjoehaines imjoehaines merged commit 2eebc50 into next Sep 5, 2023
@imjoehaines imjoehaines deleted the remove-deprecated-pkg-resources-use branch September 5, 2023 07:55
@imjoehaines imjoehaines mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants