Skip to content

wip: generate icons font #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

wip: generate icons font #4081

wants to merge 1 commit into from

Conversation

@JohnBerd
Copy link
Collaborator

@JohnBerd JohnBerd commented Apr 14, 2022 •
edited by clegirar
Loading

No description provided.

@JohnBerd JohnBerd requested review from a team as code owners April 14, 2022 08:02
@JohnBerd JohnBerd self-assigned this Apr 14, 2022
@JohnBerd JohnBerd force-pushed the feat/generate-icons-font branch 4 times, most recently from e724291 to 5fe348b Compare April 15, 2022 16:33
@codecov
Copy link

codecov bot commented Apr 15, 2022 •
edited
Loading

Codecov Report

Merging #4081 (09f52ef) into master (176c991) will increase coverage by 0.09%.
The diff coverage is 54.54%.

❗ Current head 09f52ef differs from pull request most recent head b385bff. Consider uploading reports for the commit b385bff to get more accurate results

@@            Coverage Diff             @@
##           master    #4081      +/-   ##
==========================================
+ Coverage   26.13%   26.23%   +0.09%     
==========================================
  Files         428      424       -4     
  Lines       33953    33772     -181     
  Branches     2148     2088      -60     
==========================================
- Hits         8874     8860      -14     
+ Misses      23935    23768     -167     
  Partials     1144     1144
Flag Coverage Δ
js.unittests 11.41% <54.54%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/packages/messenger-app/App.tsx 42.85% <ø> (ø)
...boarding/CustomModeSettings/CustomModeSettings.tsx 4.25% <ø> (ø)
js/packages/messenger-app/custom-icons.tsx 55.55% <54.54%> (+9.40%) ⬆️
...ages/components/chat/EnableNotificationsButton.tsx 1.63% <0.00%> (-2.07%) ⬇️
js/packages/store/convert.ts 7.14% <0.00%> (-1.43%) ⬇️
js/packages/go-bridge/index.ts 100.00% <0.00%> (ø)
js/packages/components/utils.ts 17.77% <0.00%> (ø)
js/packages/grpc-bridge/error.ts 39.39% <0.00%> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176c991...b385bff. Read the comment docs.

@JohnBerd JohnBerd force-pushed the feat/generate-icons-font branch 8 times, most recently from 035c2b4 to 525adbd Compare April 19, 2022 10:16
@JohnBerd JohnBerd force-pushed the feat/generate-icons-font branch 4 times, most recently from eaeddc1 to f00c391 Compare April 28, 2022 16:17
@n0izn0iz n0izn0iz force-pushed the feat/generate-icons-font branch 5 times, most recently from 0505736 to 1682685 Compare May 5, 2022 11:36
@JohnBerd JohnBerd requested a review from a team as a code owner May 5, 2022 11:36
@n0izn0iz n0izn0iz changed the title generate icons font WIP - generate icons font May 5, 2022
@n0izn0iz n0izn0iz force-pushed the feat/generate-icons-font branch 4 times, most recently from 24a8aad to 8db5bfb Compare May 5, 2022 14:48
@n0izn0iz n0izn0iz changed the title WIP - generate icons font generate icons font May 5, 2022
@n0izn0iz n0izn0iz force-pushed the feat/generate-icons-font branch from 8db5bfb to 0ded953 Compare May 5, 2022 15:00
@JohnBerd
feat: use ttf font instead of custom icons
b385bff 
Signed-off-by: Xavier Le Cunff <xavier.le-cunff@azot.dev>
Signed-off-by: Norman Meier <norman@berty.tech>
@n0izn0iz n0izn0iz force-pushed the feat/generate-icons-font branch from 0ded953 to b385bff Compare May 9, 2022 09:34
@clegirar clegirar changed the title generate icons font WIP: generate icons font May 9, 2022
@auto-add-label auto-add-label bot added the WIP label May 9, 2022
@aeddi aeddi removed the WIP label Jun 21, 2022
@aeddi aeddi changed the title WIP: generate icons font wip: generate icons font Jun 21, 2022
@auto-add-label auto-add-label bot added the wip label Jun 21, 2022
@glouvigny glouvigny marked this pull request as draft February 15, 2023 10:03
@jefft0 jefft0 removed request for a team April 19, 2023 08:31
@jefft0 jefft0 removed the wip label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohnBerd @jefft0 @aeddi