Skip to content

chore(commons): concatenate PT UA to AWS_SDK_UA_APP_ID when one is set #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2025

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR updates the logic for the user agent string so that when the AWS_SDK_UA_APP_ID environment variable is already set, it concatenates the Powertools for AWS UA string to the existing one.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4373


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from sdangol August 22, 2025 14:11
@dreamorosi dreamorosi self-assigned this Aug 22, 2025
@boring-cyborg boring-cyborg bot added commons This item relates to the Commons Utility tests PRs that add or change tests labels Aug 22, 2025
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Aug 22, 2025
Co-authored-by: Swopnil Dangol <swopnildangol@gmail.com>
@dreamorosi dreamorosi requested a review from sdangol August 22, 2025 15:44
Copy link

@sdangol sdangol merged commit 519cbfe into main Aug 22, 2025
38 checks passed
@sdangol sdangol deleted the chore/commons_ua_aws_sdk_env branch August 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commons This item relates to the Commons Utility size/S PR between 10-29 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: concatenate Powertools for AWS UA to existing AWS_SDK_UA_APP_ID
2 participants