-
Notifications
You must be signed in to change notification settings - Fork 168
chore(parameters): fix SonarQube code quality issues and optimize imports #4359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(parameters): fix SonarQube code quality issues and optimize imports #4359
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this PR and congrats for your first merged PR in this project!
If you're interested in picking up any other issue, we have many of similar complexity/effort.
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good. Thanks for the PR
Thank you so much for your support and guidance.. |
Summary
This pull request addresses and resolves all 9 SonarQube code quality issues identified in the
packages/parameters
package, as detailed in issue #4256. These improvements enhance maintainability, enforce immutability where intended, optimize imports, and clean up test code for clarity and reliability.Changes
1. Immutability with
readonly
Membersapplication
andenvironment
asreadonly
(lines 192, 193), making their immutability explicit.#name
asreadonly
(line 27).console
property asreadonly
(line 16).2. Import Optimization
@aws-sdk/client-dynamodb
into a single import statement (lines 5, 11).3. Union Type Improvement
get
method to remove unnecessaryundefined
from the union (line 95), improving type safety and API clarity.4. Test Cleanup
SSMProvider.ts
SSMProvider.test.ts
Issue number: closes #4256
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.