Skip to content

feat(logs): add --dag-processor and generic --component flags to deployment logs - #2131

Merged
jlaneve merged 1 commit into
mainfrom
julianlaneve/deployment-logs-component-flag
May 8, 2026
Merged

feat(logs): add --dag-processor and generic --component flags to deployment logs#2131
jlaneve merged 1 commit into
mainfrom
julianlaneve/deployment-logs-component-flag

Conversation

@jlaneve

@jlaneve jlaneve commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a --dag-processor flag to astro deployment logs. The platform API has supported this source for a while; the CLI just never exposed it.
  • Adds a generic --component flag (repeatable/comma-separated) so future API sources can be opted into without a CLI release.
  • Adds dag-processor to the default fallback set when no component flag is passed.

Test plan

  • go test ./cloud/deployment ./cmd/cloud — all green, including 3 new subtests covering --dag-processor, --component, and the updated default fallback
  • Smoke tests against a real Airflow 3 deployment:
    • astro deployment logs <id> --dag-processor returns dag-processor logs
    • astro deployment logs <id> --component dag-processor returns dag-processor logs
    • astro deployment logs <id> --component scheduler,dag-processor accepts comma-separated values
    • default fallback (no flag) returns logs tagged with both apiserver and dag-processor

🤖 Generated with Claude Code

The deployment logs command exposed scheduler/webserver/apiserver/triggerer/worker
sources but not dag-processor, which the platform API has supported for some time.
Adds a dedicated --dag-processor flag, a generic --component flag for forward-compat
with future API sources, and includes dag-processor in the default fallback when no
component flag is set.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jlaneve
jlaneve requested a review from a team as a code owner May 8, 2026 22:02
@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 25346

Coverage increased (+0.01%) to 39.756%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (12 of 13 lines covered, 92.31%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
cloud/deployment/deployment.go 10 9 90.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 65909
Covered Lines: 26203
Line Coverage: 39.76%
Coverage Strength: 9.41 hits per line

💛 - Coveralls

@jlaneve
jlaneve merged commit 7eb6e74 into main May 8, 2026
6 of 7 checks passed
@jlaneve
jlaneve deleted the julianlaneve/deployment-logs-component-flag branch May 8, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants