Skip to content

Revert image-only changes to allow pushing custom images to remote deployment - #2129

Merged
neel-astro merged 1 commit into
mainfrom
fix-remote-custom-deploy
May 8, 2026
Merged

Revert image-only changes to allow pushing custom images to remote deployment#2129
neel-astro merged 1 commit into
mainfrom
fix-remote-custom-deploy

Conversation

@neel-astro

Copy link
Copy Markdown
Contributor

Description

Changes:

  • Revert the implicit setting deploy type as image only by setting image=true when custom image is being pushed. This is to fix the issue around remote deployment that have dag deploy disabled running into issue where Astro platform will reject deploy type as image only.

Describe the purpose of this pull request.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

  • Validated that custom image push to remote deployment is working fine
Screenshot 2026-05-08 at 7 47 58 PM
  • Validated that custom image push from outside local airflow project dir is working fine for both remote and non-remote deployment
Screenshot 2026-05-08 at 7 50 52 PM

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@neel-astro
neel-astro requested a review from a team as a code owner May 8, 2026 14:26

@ianbuss ianbuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 0

Coverage decreased (-0.001%) to 39.746%

Details

  • Coverage decreased (-0.001%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 65899
Covered Lines: 26192
Line Coverage: 39.75%
Coverage Strength: 9.4 hits per line

💛 - Coveralls

@neel-astro
neel-astro enabled auto-merge (squash) May 8, 2026 14:38
@neel-astro
neel-astro merged commit c02cbe6 into main May 8, 2026
6 of 8 checks passed
@neel-astro
neel-astro deleted the fix-remote-custom-deploy branch May 8, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants