Skip to content

Conversation

jesmith-all
Copy link

  • Adds optional argument to WifiConnectionHandler constructor to pass a username
  • Conditional in .cpp checks if value has been set, calls on .begin or .beginEnterprise accordingly
  • Critical to use at universities
  • If merged, would allow students on university networks to use IoT Cloud without modifying a local copy of the library

…ditional to substitute Wifi.beginEnterprise method() when modified from default value.
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2021

CLA assistant check
All committers have signed the CLA.

@facchinm
Copy link
Contributor

Hi @jesmith-all ,
thanks for the PR! However, the API is a bit confusing IMO; I'd prefer a derived class similar to #63 that could be "selected" by the user as soon as arduino-libraries/ArduinoIoTCloud#265 get merged and the online "stub" generator updated.
This would allow calling beginEnterprise() with all the different options (like entity/ca if needed).

@jesmith-all
Copy link
Author

@facchinm (@brownby)

Fair enough. With an active course now and more around the corner, I sought the path of least resistance in edits that would add the functionality as a stop gap, but you're right that this isn't as clean as it could be.

I have not been tracking these other developments, but it's great to hear that you've got a vision for how things could coalesce. I'll take a look and circle back.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself status: changes requested Changes to PR are required before merge labels May 15, 2022
@per1234 per1234 linked an issue May 15, 2022 that may be closed by this pull request
@olipinski
Copy link

@facchinm Does it still need to be in a derived class? I see that the project file structure has changed quite a bit since this PR, but if it still needs to be a separate class, I can give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes requested Changes to PR are required before merge topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WiFi Handler for WPA2 Enterprise networks
5 participants