Skip to content

Support for WPA2 Enterprise #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support for WPA2 Enterprise #65

wants to merge 3 commits into from

Conversation

jesmith-all
Copy link

  • Adds optional argument to WifiConnectionHandler constructor to pass a username
  • Conditional in .cpp checks if value has been set, calls on .begin or .beginEnterprise accordingly
  • Critical to use at universities
  • If merged, would allow students on university networks to use IoT Cloud without modifying a local copy of the library

@jesmith-all
Add optional argument (user) to WifiConnectionHandler and related con…
ac01755 
…ditional to substitute Wifi.beginEnterprise method() when modified from default value.
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jesmith-all jesmith-all mentioned this pull request Aug 9, 2021
Open
@facchinm
Copy link
Contributor

Hi @jesmith-all ,
thanks for the PR! However, the API is a bit confusing IMO; I'd prefer a derived class similar to #63 that could be "selected" by the user as soon as arduino-libraries/ArduinoIoTCloud#265 get merged and the online "stub" generator updated.
This would allow calling beginEnterprise() with all the different options (like entity/ca if needed).

@jesmith-all
Copy link
Author

@facchinm (@brownby)

Fair enough. With an active course now and more around the corner, I sought the path of least resistance in edits that would add the functionality as a stop gap, but you're right that this isn't as clean as it could be.

I have not been tracking these other developments, but it's great to hear that you've got a vision for how things could coalesce. I'll take a look and circle back.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself status: changes requested Changes to PR are required before merge labels May 15, 2022
@per1234 per1234 linked an issue May 15, 2022 that may be closed by this pull request
WiFi Handler for WPA2 Enterprise networks #64
Open
@olipinski
Copy link

@facchinm Does it still need to be in a derived class? I see that the project file structure has changed quite a bit since this PR, but if it still needs to be a separate class, I can give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: changes requested Changes to PR are required before merge topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WiFi Handler for WPA2 Enterprise networks
5 participants
@jesmith-all @CLAassistant @facchinm @olipinski @per1234