Skip to content

Cleaning up mqtt client definition #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Cleaning up mqtt client definition #120

wants to merge 2 commits into from

Conversation

andreagilardoni
Copy link

@andreagilardoni andreagilardoni commented Jul 28, 2025 •
edited
Loading

There is no need to provide overloaded version of methods for C-String and Arduino-String. Providing only Arduino-String methods is enough since C-String can be used to implicitly in Arduino String constructor

@andreagilardoni
codestyle unification
81ce835
@andreagilardoni
Removing redundant methods that use char* instrad of String
a797658 
This will simplify the definition of the class since String class is
automatically built by providinc a C-string
@github-actions GitHub Actions
Copy link

Memory usage change @ a797658

Board flash % RAM for global variables %
arduino:esp32:nano_nora ❔ -68 - +64 -0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:megaavr:uno2018 🔺 +78 - +148 +0.16 - +0.3 0 - 0 0.0 - 0.0
arduino:renesas_portenta:portenta_c33 🔺 +8 - +32 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +16 - +32 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 +8 - +32 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 +8 - +32 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 +8 - +32 0.0 - +0.01 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +8 - +256 0.0 - +0.02 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah N/A N/A N/A N/A
Click for full report table
Board examples/WiFiAdvancedCallback
flash		 % examples/WiFiAdvancedCallback
RAM for global variables		 % examples/WiFiEcho
flash		 % examples/WiFiEcho
RAM for global variables		 % examples/WiFiEchoCallback
flash		 % examples/WiFiEchoCallback
RAM for global variables		 % examples/WiFiSimpleReceive
flash		 % examples/WiFiSimpleReceive
RAM for global variables		 % examples/WiFiSimpleReceiveCallback
flash		 % examples/WiFiSimpleReceiveCallback
RAM for global variables		 % examples/WiFiSimpleSender
flash		 % examples/WiFiSimpleSender
RAM for global variables		 %
arduino:esp32:nano_nora -68 -0.0 0 0.0 -16 -0.0 0 0.0 64 0.0 0 0.0 -60 -0.0 0 0.0 -60 -0.0 0 0.0 -68 -0.0 0 0.0
arduino:mbed_giga:giga 64 0.0 0 0.0 0 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 0 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:megaavr:uno2018 136 0.28 0 0.0 148 0.3 0 0.0 128 0.26 0 0.0 78 0.16 0 0.0 78 0.16 0 0.0 78 0.16 0 0.0
arduino:renesas_portenta:portenta_c33 24 0.0 0 0.0 24 0.0 0 0.0 32 0.0 0 0.0 16 0.0 0 0.0 8 0.0 0 0.0 16 0.0 0 0.0
arduino:renesas_uno:unor4wifi 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
arduino:samd:mkr1000 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 24 0.01 0 0.0
arduino:samd:mkrwifi1010 32 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0
arduino:samd:nano_33_iot 32 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0
esp32:esp32:esp32 8 0.0 0 0.0 152 0.01 0 0.0 256 0.02 0 0.0 32 0.0 0 0.0 32 0.0 0 0.0 68 0.01 0 0.0
esp8266:esp8266:huzzah N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/WiFiAdvancedCallback<br>flash,%,examples/WiFiAdvancedCallback<br>RAM for global variables,%,examples/WiFiEcho<br>flash,%,examples/WiFiEcho<br>RAM for global variables,%,examples/WiFiEchoCallback<br>flash,%,examples/WiFiEchoCallback<br>RAM for global variables,%,examples/WiFiSimpleReceive<br>flash,%,examples/WiFiSimpleReceive<br>RAM for global variables,%,examples/WiFiSimpleReceiveCallback<br>flash,%,examples/WiFiSimpleReceiveCallback<br>RAM for global variables,%,examples/WiFiSimpleSender<br>flash,%,examples/WiFiSimpleSender<br>RAM for global variables,%
arduino:esp32:nano_nora,-68,-0.0,0,0.0,-16,-0.0,0,0.0,64,0.0,0,0.0,-60,-0.0,0,0.0,-60,-0.0,0,0.0,-68,-0.0,0,0.0
arduino:mbed_giga:giga,64,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:megaavr:uno2018,136,0.28,0,0.0,148,0.3,0,0.0,128,0.26,0,0.0,78,0.16,0,0.0,78,0.16,0,0.0,78,0.16,0,0.0
arduino:renesas_portenta:portenta_c33,24,0.0,0,0.0,24,0.0,0,0.0,32,0.0,0,0.0,16,0.0,0,0.0,8,0.0,0,0.0,16,0.0,0,0.0
arduino:renesas_uno:unor4wifi,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0
arduino:samd:mkr1000,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,24,0.01,0,0.0
arduino:samd:mkrwifi1010,32,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0
arduino:samd:nano_33_iot,32,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0
esp32:esp32:esp32,8,0.0,0,0.0,152,0.01,0,0.0,256,0.02,0,0.0,32,0.0,0,0.0,32,0.0,0,0.0,68,0.01,0,0.0
esp8266:esp8266:huzzah,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andreagilardoni