Skip to content

Enable BearSSL Offload for MKR WiFi 1010 and Nano 33 IoT #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 9, 2021
Merged

Enable BearSSL Offload for MKR WiFi 1010 and Nano 33 IoT #237

merged 7 commits into from
Apr 9, 2021

Conversation

aentinger
Copy link
Contributor

Therefore freeing a considerate amount of Flash/RAM on ATSAMD21G18.

Supersedes #234.

@aentinger aentinger added the type: enhancement Proposed improvement label Apr 7, 2021
@aentinger aentinger self-assigned this Apr 7, 2021
@aentinger aentinger mentioned this pull request Apr 7, 2021
Closed
@codecov-io
Copy link

codecov-io commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #237 (66b2e47) into master (34a8d30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          24       24           
  Lines         867      867           
=======================================
  Hits          825      825           
  Misses         42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b531a03...66b2e47. Read the comment docs.

aentinger added 5 commits April 7, 2021 14:19
@aentinger
This change enabled BearSSL offload for Arduino MKR WiFi 1010 and Nan…
d8a9965 
…o 33 IoT.
@aentinger
Bugfix: Don't call ECCX08::end() as it disable the I2C module.
fd0bb72 
This has the unpleasant side-effect that any future access to the I2C bus is trying to access an uninitialized I2C module and gets stuck in a loop.
@aentinger
Provide strong implementation in order to override 'wifi_nina_feed_wa…
d766bb3 
…tchdog' defined weak within WiFiNINA.
@aentinger
Allow central enabling/disabling of watchdog for SAMD within AIoTConf…
ba61452 
…ig.h
@aentinger
Provide error message when NINA firmware is < 1.4.3 if the user wants…
11ac436 
… to take advantage of SSL offloading.
@aentinger aentinger force-pushed the enable-bearssl-offload-samd-watchdog branch from 8596b6f to 11ac436 Compare April 7, 2021 12:19
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

Memory usage change @ 2ce0578

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 +40 - +56 +0.02 - +0.02 🔺 +4 - +20 +0.01 - +0.06
arduino:samd:mkrwifi1010 💚 -51216 - 0 -19.54 - 0.0 💚 -15304 - 0 -46.7 - 0.0
arduino:samd:nano_33_iot 💚 -51216 - 0 -19.54 - 0.0 💚 -15304 - 0 -46.7 - 0.0
esp32:esp32:esp32 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 % examples/ArduinoIoTCloud-Advanced
RAM for global variables		 % examples/ArduinoIoTCloud-Basic
flash		 % examples/ArduinoIoTCloud-Basic
RAM for global variables		 % examples/utility/ArduinoIoTCloud_Travis_CI
flash		 % examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 % examples/utility/Provisioning
flash		 % examples/utility/Provisioning
RAM for global variables		 % examples/utility/SelfProvisioning
flash		 % examples/utility/SelfProvisioning
RAM for global variables		 %
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 56 0.02 20 0.06 56 0.02 20 0.06 40 0.02 4 0.01
arduino:samd:mkrwifi1010 -51216 -19.54 -15304 -46.7 -51216 -19.54 -15304 -46.7 -51216 -19.54 -15304 -46.7 -47876 -18.26 -15304 -46.7 0 0.0 0 0.0
arduino:samd:nano_33_iot -50968 -19.44 -15296 -46.68 -51216 -19.54 -15304 -46.7 -50968 -19.44 -15296 -46.68 -47620 -18.17 -15296 -46.68 0 0.0 0 0.0
esp32:esp32:esp32 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp8266:esp8266:huzzah 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,56,0.02,20,0.06,56,0.02,20,0.06,40,0.02,4,0.01,,,,
arduino:samd:mkrwifi1010,-51216,-19.54,-15304,-46.7,-51216,-19.54,-15304,-46.7,-51216,-19.54,-15304,-46.7,-47876,-18.26,-15304,-46.7,0,0.0,0,0.0
arduino:samd:nano_33_iot,-50968,-19.44,-15296,-46.68,-51216,-19.54,-15304,-46.7,-50968,-19.44,-15296,-46.68,-47620,-18.17,-15296,-46.68,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

@aentinger
Replace compile-time configuration of watchdog (compiled in/out) with…
66b2e47 
… parameter in 'begin' function.

The watchdog is now always compiled in, but can be disabled when setting the parameter 'enable_watchdog' too false. The parameter is set to true by default.
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Memory usage change @ 66b2e47

Board flash % RAM for global variables %
arduino:mbed:envie_m4 🔺 0 - +64 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 +24 - +72 +0.01 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 +16 - +64 +0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 +24 - +72 +0.01 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 +40 - +56 +0.02 - +0.02 🔺 +4 - +20 +0.01 - +0.06
arduino:samd:mkrwifi1010 💚 -51168 - 0 -19.52 - 0.0 💚 -15304 - 0 -46.7 - 0.0
arduino:samd:nano_33_iot 💚 -51168 - 0 -19.52 - 0.0 💚 -15304 - 0 -46.7 - 0.0
esp32:esp32:esp32 🔺 +16 - +16 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +16 - +16 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 % examples/ArduinoIoTCloud-Advanced
RAM for global variables		 % examples/ArduinoIoTCloud-Basic
flash		 % examples/ArduinoIoTCloud-Basic
RAM for global variables		 % examples/utility/ArduinoIoTCloud_Travis_CI
flash		 % examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 % examples/utility/Provisioning
flash		 % examples/utility/Provisioning
RAM for global variables		 % examples/utility/SelfProvisioning
flash		 % examples/utility/SelfProvisioning
RAM for global variables		 %
arduino:mbed:envie_m4 0 0.0 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 72 0.03 0 0.0 64 0.02 0 0.0 72 0.03 0 0.0 24 0.01 0 0.0
arduino:samd:mkrgsm1400 64 0.02 0 0.0 64 0.02 0 0.0 64 0.02 0 0.0 16 0.01 0 0.0
arduino:samd:mkrnb1500 64 0.02 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 24 0.01 0 0.0
arduino:samd:mkrwan1300 56 0.02 20 0.06 56 0.02 20 0.06 40 0.02 4 0.01
arduino:samd:mkrwifi1010 -51168 -19.52 -15304 -46.7 -51168 -19.52 -15304 -46.7 -51168 -19.52 -15304 -46.7 -47868 -18.26 -15304 -46.7 0 0.0 0 0.0
arduino:samd:nano_33_iot -50920 -19.42 -15296 -46.68 -51168 -19.52 -15304 -46.7 -50920 -19.42 -15296 -46.68 -47620 -18.17 -15296 -46.68 0 0.0 0 0.0
esp32:esp32:esp32 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0
esp8266:esp8266:huzzah 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,72,0.03,0,0.0,64,0.02,0,0.0,72,0.03,0,0.0,24,0.01,0,0.0
arduino:samd:mkrgsm1400,64,0.02,0,0.0,64,0.02,0,0.0,64,0.02,0,0.0,16,0.01,0,0.0
arduino:samd:mkrnb1500,64,0.02,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,24,0.01,0,0.0
arduino:samd:mkrwan1300,56,0.02,20,0.06,56,0.02,20,0.06,40,0.02,4,0.01,,,,
arduino:samd:mkrwifi1010,-51168,-19.52,-15304,-46.7,-51168,-19.52,-15304,-46.7,-51168,-19.52,-15304,-46.7,-47868,-18.26,-15304,-46.7,0,0.0,0,0.0
arduino:samd:nano_33_iot,-50920,-19.42,-15296,-46.68,-51168,-19.52,-15304,-46.7,-50920,-19.42,-15296,-46.68,-47620,-18.17,-15296,-46.68,0,0.0,0,0.0
esp32:esp32:esp32,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,,,,,,,,

@aentinger aentinger mentioned this pull request Apr 8, 2021
Merged
@aentinger aentinger marked this pull request as ready for review April 9, 2021 05:36
@aentinger aentinger merged commit 76e8e84 into master Apr 9, 2021
@aentinger aentinger deleted the enable-bearssl-offload-samd-watchdog branch April 9, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aentinger @codecov-io