Skip to content

Add ability to set response wait time #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2024
Merged

Add ability to set response wait time #158

merged 3 commits into from
Mar 21, 2024

Conversation

BeppeInfo
Copy link

In my use cases a good amount of requests take way less than 1000 milliseconds to get a reply

I would like a way to use less delay than kHttpWaitForDataDelay to avoid unnecessarily hurting performance

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Memory usage change @ c490dde

Board flash % RAM for global variables %
arduino:samd:mkr1000 🔺 +8 - +24 0.0 - +0.01 🔺 +4 - +8 +0.01 - +0.02
Click for full report table
Board examples/BasicAuthGet
flash		 % examples/BasicAuthGet
RAM for global variables		 % examples/CustomHeader
flash		 % examples/CustomHeader
RAM for global variables		 % examples/DweetGet
flash		 % examples/DweetGet
RAM for global variables		 % examples/DweetPost
flash		 % examples/DweetPost
RAM for global variables		 % examples/HueBlink
flash		 % examples/HueBlink
RAM for global variables		 % examples/PostWithHeaders
flash		 % examples/PostWithHeaders
RAM for global variables		 % examples/SimpleDelete
flash		 % examples/SimpleDelete
RAM for global variables		 % examples/SimpleGet
flash		 % examples/SimpleGet
RAM for global variables		 % examples/SimpleHttpExample
flash		 % examples/SimpleHttpExample
RAM for global variables		 % examples/SimplePost
flash		 % examples/SimplePost
RAM for global variables		 % examples/SimplePut
flash		 % examples/SimplePut
RAM for global variables		 % examples/SimpleWebSocket
flash		 % examples/SimpleWebSocket
RAM for global variables		 %
arduino:samd:mkr1000 16 0.01 4 0.01 16 0.01 4 0.01 8 0.0 4 0.01 16 0.01 4 0.01 8 0.0 4 0.01 16 0.01 4 0.01 8 0.0 4 0.01 16 0.01 4 0.01 16 0.01 4 0.01 16 0.01 4 0.01 16 0.01 4 0.01 24 0.01 8 0.02
Click for full report CSV 
Board,examples/BasicAuthGet<br>flash,%,examples/BasicAuthGet<br>RAM for global variables,%,examples/CustomHeader<br>flash,%,examples/CustomHeader<br>RAM for global variables,%,examples/DweetGet<br>flash,%,examples/DweetGet<br>RAM for global variables,%,examples/DweetPost<br>flash,%,examples/DweetPost<br>RAM for global variables,%,examples/HueBlink<br>flash,%,examples/HueBlink<br>RAM for global variables,%,examples/PostWithHeaders<br>flash,%,examples/PostWithHeaders<br>RAM for global variables,%,examples/SimpleDelete<br>flash,%,examples/SimpleDelete<br>RAM for global variables,%,examples/SimpleGet<br>flash,%,examples/SimpleGet<br>RAM for global variables,%,examples/SimpleHttpExample<br>flash,%,examples/SimpleHttpExample<br>RAM for global variables,%,examples/SimplePost<br>flash,%,examples/SimplePost<br>RAM for global variables,%,examples/SimplePut<br>flash,%,examples/SimplePut<br>RAM for global variables,%,examples/SimpleWebSocket<br>flash,%,examples/SimpleWebSocket<br>RAM for global variables,%
arduino:samd:mkr1000,16,0.01,4,0.01,16,0.01,4,0.01,8,0.0,4,0.01,16,0.01,4,0.01,8,0.0,4,0.01,16,0.01,4,0.01,8,0.0,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,16,0.01,4,0.01,24,0.01,8,0.02

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 5, 2023
@andreagilardoni andreagilardoni self-requested a review March 21, 2024 14:41
@andreagilardoni andreagilardoni merged commit 5c5fafb into arduino-libraries:master Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreagilardoni andreagilardoni andreagilardoni approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BeppeInfo @CLAassistant @andreagilardoni @per1234