-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update repository.txt #6829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update repository.txt #6829
Conversation
add DUE_Oversampler
adding Arduino Due RS485 DMA library
adding NitrofMtl/ArduinoModbus-DUE-DMA a modbus lib to work with DUERS485DMA library
A problem was found with your submission https://github.com/NitrofMtl/DUE_ADC_Oversampler ❌ ERROR: Submission URL is already in the Library Manager index. |
❌ ERROR: Arduino Lint found errors with https://github.com/NitrofMtl/ArduinoModbus-DUE-DMA:
|
Arduino Lint has suggestions for possible improvements to https://github.com/NitrofMtl/DUERS485DMA:
|
Thanks for your interest in contributing to the Arduino Library Manager index @NitrofMtl After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @NitrofMtl. Thanks for your interest in contributing to the Arduino Library Manager.
I see the bot reported two problems with your submission that will block its acceptance:
Duplicate Submission
A problem was found with your submission >https://github.com/NitrofMtl/DUE_ADC_Oversampler
❌ ERROR: Submission URL is already in the Library Manager index.
This is caused by you submitting the pull request from a branch of your fork that contains changes from your previous pull request, and which is also out of sync with this repository.
Please sync the main
branch of your fork repository.
In the future, make sure to always create a dedicated branch in your fork repository for each pull request. You should never make any commits directly in the default branch (i.e., main
) in your fork. The revision history of the default branch in your fork should always match the default branch in this repository exactly. This way, you can use the default branch as the base for the branches you create for your pull requests. Your use of the default branch in your repository for this pull request is the cause of these unnecessary problems.
You can learn how to correctly use branches for pull requests from this tutorial:
Always make sure the default branch in your fork is in sync with the default branch in this repository before you create a branch for a pull request. You can learn how to sync the branch in your fork from the documentation here:
Prohibited Library Name
❌ ERROR: Arduino Lint found errors with https://github.com/NitrofMtl/ArduinoModbus-DUE-DMA:
ERROR: Library name ArduinoModbus starts with "Arduino". These names are reserved for official libraries. See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format (Rule LP012) ERROR: Library name ArduinoModbus is in use by a library in the Library Manager index. Each library must have a unique name value. If your library is already in the index, use the "--library-manager update" flag. See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format (Rule LP017)
Please fix the problem so we can proceed with your submission.
You will need to do the following things:
- Change the value of the
name
property in your library'slibrary.properties
metadata file to a name that meets the following requirements:- Is unique. You can check whether prospective names are taken by searching the Arduino IDE Library Manager.
- Does not start with
arduino
.
- Bump the value of the
version
property in the library'slibrary.properties
metadata file. - Create a new release or tag in the library repository.
- Add a comment here in the pull request thread that mentions @ArduinoBot.
After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
Hello! I'm checking your submission again. |
A problem was found with your submission https://github.com/NitrofMtl/DUE_ADC_Oversampler ❌ ERROR: Submission URL is already in the Library Manager index. |
Arduino Lint has suggestions for possible improvements to https://github.com/NitrofMtl/DUERS485DMA:
|
Arduino Lint has suggestions for possible improvements to https://github.com/NitrofMtl/ArduinoModbus-DUE-DMA:
|
Thanks for your interest in contributing to the Arduino Library Manager index @NitrofMtl After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
Hello! I'm checking your submission again. |
A problem was found with your submission https://github.com/NitrofMtl/DUE_ADC_Oversampler ❌ ERROR: Submission URL is already in the Library Manager index. |
Arduino Lint has suggestions for possible improvements to https://github.com/NitrofMtl/ArduinoModbus-DUE-DMA:
|
Thanks for your interest in contributing to the Arduino Library Manager index @NitrofMtl After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NitrofMtl. I see you fixed the "prohibited library name" problem with https://github.com/NitrofMtl/ArduinoModbus-DUE-DMA. However, you have not fixed the other "duplicate submission" problem.
I already provided a detailed explanation of what you need to do to fix that problem:
Please read it very carefully and fix your pull request. Since you are competent enough to publish multiple Arduino libraries, this simple operation of submitting a pull request to add a couple of lines to a text file is something you should have no difficulty accomplishing.
add to repository:
-https://github.com/NitrofMtl/DUERS485DMA
-https://github.com/NitrofMtl/ArduinoModbus-DUE-DMA