Skip to content

Conversation

murilopolese
Copy link
Contributor

Clean non-ascii characters on filenames the same way we do with the file content.

@murilopolese murilopolese requested a review from ubidefeo July 6, 2023 14:58
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubidefeo ubidefeo requested a review from kittaakos July 7, 2023 07:32
Co-authored-by: Akos Kitta <1405703+kittaakos@users.noreply.github.com>
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittaakos requested a fix and it's now double approved

@ubidefeo ubidefeo merged commit 9dedd05 into main Jul 7, 2023
@ubidefeo ubidefeo deleted the bugfix/non-ascii-filenames branch July 7, 2023 11:55
@per1234 per1234 added the bug Something isn't working label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants