Skip to content

Refactor serial connection handler #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Refactor serial connection handler #158

wants to merge 9 commits into from

Conversation

sebromero
Copy link
Collaborator

This PR refactors the serial connection handler so it can be safely used in the renderer and the main process.

@sebromero sebromero changed the base branch from main to feature/shortcuts December 11, 2024 15:45
@sebromero sebromero requested a review from Copilot December 12, 2024 08:29
Copilot
Copilot AI reviewed Dec 12, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • backend/bridge/serial-bridge.js: Evaluated as low risk
  • backend/ipc.js: Evaluated as low risk
  • backend/menu.js: Evaluated as low risk

@sebromero sebromero mentioned this pull request Dec 12, 2024
Merged
Base automatically changed from feature/shortcuts to development December 13, 2024 11:47
@ubidefeo
Copy link
Collaborator

@sebromero
with #153 merged, you can now try and rebase this on development and request a review

@sebromero
Copy link
Collaborator Author

@ubidefeo Rebased. Needs some testing.

@sebromero sebromero closed this Dec 16, 2024
@sebromero sebromero deleted the close-fix branch December 16, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebromero @ubidefeo