Skip to content

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Sep 14, 2022

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?

Feature

What is the current behavior?

A build for macos arm64 (M1) is not provided.

What is the new behavior?

The workflow release-go-task and DistTasks have been updated to handle the darwin_arm64 release and now match the corresponding ones present in the tooling-project-assets repository.

Other information:

Here you can check the workflow run: https://github.com/MatteoPologruto/arduino-language-server/actions/runs/3053770326
And this is the release it created: https://github.com/MatteoPologruto/arduino-language-server/releases/tag/0.0.2


@MatteoPologruto MatteoPologruto added os: macos Specific to macOS operating system architecture: arm Specific to ARM host architecture topic: infrastructure Related to project infrastructure labels Sep 14, 2022
@MatteoPologruto MatteoPologruto self-assigned this Sep 14, 2022
@MatteoPologruto MatteoPologruto marked this pull request as ready for review September 14, 2022 12:42
@MatteoPologruto MatteoPologruto force-pushed the arm64-support branch 2 times, most recently from 577287e to 95f1672 Compare September 14, 2022 14:47
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @MatteoPologruto 💟

@MatteoPologruto MatteoPologruto merged commit 6589758 into arduino:main Sep 19, 2022
@MatteoPologruto MatteoPologruto deleted the arm64-support branch September 19, 2022 15:16
@per1234 per1234 added the type: enhancement Proposed improvement label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture: arm Specific to ARM host architecture os: macos Specific to macOS operating system topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants