Skip to content

Add CI workflow to lint and check formatting of Go code #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 4, 2022
Merged

Add CI workflow to lint and check formatting of Go code #128

merged 8 commits into from
Aug 4, 2022

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce?

Infrastructure enhancement

  • What is the current behavior?

The repository's Go module is not being checked.

  • What is the new behavior?

On every push and pull request that affects relevant files, check the repository's Go module for:

  • Common detectable errors in the code.
  • Use of outdated APIs
  • Code style violations
  • Code formatting inconsistency
  • Misconfiguration

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 2, 2022
@MatteoPologruto MatteoPologruto self-assigned this Aug 2, 2022
@MatteoPologruto MatteoPologruto force-pushed the check-go branch 2 times, most recently from 400503f to 08f34e0 Compare August 3, 2022 09:06
@MatteoPologruto MatteoPologruto marked this pull request as ready for review August 3, 2022 09:20
@MatteoPologruto
Copy link
Contributor Author

Some style checks are still failing because I didn't know how to comment some exported go functions and types. @cmaglie can you please take a look at them? Furthermore, if you have any suggestions on how to improve the comments I already wrote, please feel free to point them out.

@MatteoPologruto
Add CI workflow to lint and check formatting of Go code
983d069 
On every push and pull request that affects relevant files, check the Go module for:

- Common detectable errors in the code.
- Use of outdated APIs
- Code style violations
- Code formatting inconsistency
- Misconfiguration
@cmaglie cmaglie force-pushed the check-go branch 2 times, most recently from 10cadc2 to 523addf Compare August 4, 2022 09:09
@cmaglie cmaglie merged commit 24cb630 into main Aug 4, 2022
@cmaglie cmaglie deleted the check-go branch August 4, 2022 12:20
@MatteoPologruto MatteoPologruto mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@per1234 per1234 Awaiting requested review from per1234

@umbynos umbynos Awaiting requested review from umbynos

Assignees

@MatteoPologruto MatteoPologruto

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatteoPologruto @cmaglie