Skip to content

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 9, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?

Currently we only get a serial object formatted like this {"D":"output text here\r\n"}

  • What is the new behavior?

The output now includes the port generating the output:

{
    "P": "dev/ttyACM0",
    "D":"output text here\r\n"
}
  • Does this PR introduce a breaking change?

Probably not

  • Other information:

@umbynos umbynos self-assigned this Feb 9, 2021
@umbynos
Copy link
Contributor Author

umbynos commented Feb 9, 2021

@smellai please test binaries here

@umbynos umbynos added the type: enhancement Proposed improvement label Feb 9, 2021
@umbynos umbynos requested a review from smellai February 9, 2021 16:48
@umbynos umbynos merged commit b3860b0 into devel Feb 11, 2021
@umbynos umbynos deleted the umbynos/serial_port branch February 11, 2021 14:55
umbynos added a commit that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants