Fix concurrent access to libraries manager gRPC functions. #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of the Index* fileds inside LibraryManager didn't give any functional benefit.
It does make things more complicated without any actual benefit.
The original LibrariresManager has been split into three objects with specific goals: * The Builder object is used to construct a new LibrariesManager. It has methods to add librarires directories and to build the LibrariesManager. * The Explorer object is used to query the LibrariesManager about installed libraries. * The Installer object is used to rescan installed libraries and to install and uninstall.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2480 +/- ##
==========================================
+ Coverage 67.55% 67.61% +0.06%
==========================================
Files 207 205 -2
Lines 20759 20844 +85
==========================================
+ Hits 14023 14094 +71
- Misses 5590 5597 +7
- Partials 1146 1153 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This PR aims to make all library-related commands behave correctly when used in high-concurrency environments.
What is the current behavior?
No behavior changes (in theory...).
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Should fix #2457