Make USART IRQ handler WEAK #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: This patch modifies the predefined USART IRQ handlers in the Arduino Due core to be declared __attribute__((weak)). Motivation: - Allows libraries, such as ['DUERS485DMA'](https://github.com/NitrofMtl/DUERS485DMA), to override the default USART interrupt handlers. - Necessary for DMA-based RS485 implementations that require custom IRQ handling without modifying the core itself. Changes: - All predefined USARTx_Handler() functions are now weak. - Existing functionality remains unchanged if no library overrides the handler. - No effect on boards or configurations that do not use these handlers. Impact: - Compatible with existing sketches using standard Serial objects. - Enables advanced libraries to implement DMA or custom serial processing. Notes: - Only the weak attribute is added; the logic inside the handlers is untouched. - Users may override handlers selectively (only the USARTs they use).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This patch modifies the predefined USART IRQ handlers in the Arduino Due core to be declared attribute((weak)).
Motivation:
Allows libraries, such as 'DUERS485DMA', to override the default USART interrupt handlers.
Necessary for DMA-based RS485 implementations that require custom IRQ handling without modifying the core itself.
Changes:
All predefined USARTx_Handler() functions are now weak.
Existing functionality remains unchanged if no library overrides the handler.
No effect on boards or configurations that do not use these handlers.
Impact:
Compatible with existing sketches using standard Serial objects.
Enables advanced libraries to implement DMA or custom serial processing.
Notes:
Only the weak attribute is added; the logic inside the handlers is untouched.
Users may override handlers selectively (only the USARTs they use).