Skip to content

libraries/SoftwareSerial: Fix ring buffer data type. #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

libraries/SoftwareSerial: Fix ring buffer data type. #314

merged 1 commit into from
May 13, 2024

Conversation

iabdalkader
Copy link
Contributor

Fixes #243.

@iabdalkader
libraries/SoftwareSerial: Fix ring buffer data type.
144688e 
Fixes arduino#243.

Signed-off-by: iabdalkader <i.abdalkader@gmail.com>
@iabdalkader iabdalkader force-pushed the software_serial_fix branch from 059f0a2 to 144688e Compare May 13, 2024 11:52
@iabdalkader iabdalkader requested a review from facchinm May 13, 2024 11:52
@facchinm facchinm merged commit fe72ebf into arduino:main May 13, 2024
@iabdalkader iabdalkader deleted the software_serial_fix branch May 13, 2024 13:15
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In SoftwareSerial, the ring buffer is defined as a signed char, which causes corruption
3 participants
@iabdalkader @per1234 @facchinm