Skip to content

Allow creating IPAddress object from string and provide = overload #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2022
Merged

Allow creating IPAddress object from string and provide = overload #174

merged 3 commits into from
Dec 21, 2022

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Oct 12, 2022

No description provided.

@pennam pennam requested review from facchinm and aentinger October 12, 2022 10:54
@aentinger aentinger changed the title Allow creating IPAddress object from sting and provide = overload Allow creating IPAddress object from string and provide = overload Oct 12, 2022
aentinger
aentinger approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pennam
Copy link
Contributor Author

pennam commented Oct 14, 2022

Fixed typo in commit message

per1234
per1234 requested changes Oct 14, 2022
View reviewed changes
pennam and others added 2 commits October 14, 2022 16:15
@pennam @per1234
Fix typo in comment
53f3f29 
Co-authored-by: per1234 <accounts@perglass.com>
@pennam @per1234
Fix typo in comment
f25d3c8 
Co-authored-by: per1234 <accounts@perglass.com>
@pennam
Copy link
Contributor Author

pennam commented Oct 14, 2022

1 commit 3 typos 😭 thanks @per1234

@facchinm facchinm merged commit 9821ad0 into arduino:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@facchinm facchinm Awaiting requested review from facchinm

+1 more reviewer

@aentinger aentinger aentinger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pennam @aentinger @per1234 @facchinm