tests/resources/sites/astro/src/pages/cookies.js (1)

2-3: Set an explicit content-type for predictable client behavior

Returning a Response without a content-type relies on client heuristics. Make it explicit to avoid future surprises and to aid debugging.

-  return new Response(sessionId);
+  return new Response(sessionId, {
+    headers: {
+      'content-type': 'text/plain; charset=utf-8',
+    },
+  });

tests/e2e/Services/Sites/SitesCustomServerTest.php (3)

2701-2701: Reduce potential flakiness with Retry attribute

Similar E2E tests use Retry, which helps when infra (proxy/runtimes) is momentarily slow. Recommend adding it here as well.

-    public function testCookieHeader()
+    #[Retry(count: 3)]
+    public function testCookieHeader()

---

2726-2736: Broaden assertions: multi-cookie parsing and missing-cookie fallback

Two quick follow-ups make this test more robust:

• Ensure the target cookie is correctly extracted when multiple cookies are present.
• Verify the fallback message when the cookie is absent (matches the handler).

         $response = $proxyClient->call(Client::METHOD_GET, '/cookies', [
             'cookie' => 'custom-session-id=abcd123'
         ]);
 
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals("abcd123", $response['body']);
 
+        // Multiple cookies: ensure correct extraction
+        $response = $proxyClient->call(Client::METHOD_GET, '/cookies', [
+            'cookie' => 'foo=bar; custom-session-id=abcd123; baz=qux'
+        ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals("abcd123", $response['body']);
+
+        // Missing cookie: verify fallback behavior from the route handler
+        $response = $proxyClient->call(Client::METHOD_GET, '/cookies', [
+            'cookie' => 'foo=bar'
+        ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals("Custom session ID missing", $response['body']);

---

2717-2729: Minor: reuse existing $domain instead of re-querying

You already get $domain from setupSiteDomain($siteId). Unless you specifically need the value from getSiteDomain(), you can reuse the existing variable and avoid the extra call.

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

tests/resources/sites/astro/src/pages/cookies.js (1)

1-4: LGTM: endpoint correctly echoes the cookie value

The handler uses Astro’s cookies API and returns the expected plain-text body, matching the E2E test expectations.

tests/e2e/Services/Sites/SitesCustomServerTest.php (1)

2701-2738: LGTM: solid E2E coverage that validates cookie forwarding

The test provisions an Astro SSR site, deploys it, sends a Cookie header, and asserts the echoed value. Flow and assertions look good, and cleanup is handled.