-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore(sdk): improve dart flutter pub dev score #10340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.7.x
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughUpdates app/config/platforms.php to bump SDK versions:
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
* utopia-php/database from 0.71.14 to 0.71.15 * utopia-php/framework from 0.33.20 to 0.33.21 * appwrite/sdk-generator from 0.41.29 to 0.41.31
5baa9bf
to
5552727
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (3)
composer.lock
is excluded by!**/*.lock
docs/examples/1.7.x/client-flutter/examples/functions/create-execution.md
is excluded by!docs/examples/**
docs/sdks/flutter/CHANGELOG.md
is excluded by!docs/sdks/**
📒 Files selected for processing (1)
app/config/platforms.php
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: E2E Service Test (Storage)
- GitHub Check: E2E Service Test (Sites)
- GitHub Check: E2E Service Test (Migrations)
- GitHub Check: E2E Service Test (Tokens)
- GitHub Check: E2E Service Test (Health)
- GitHub Check: E2E Service Test (Webhooks)
- GitHub Check: E2E Service Test (Teams)
- GitHub Check: E2E Service Test (Proxy)
- GitHub Check: E2E Service Test (Projects)
- GitHub Check: E2E Service Test (Account)
- GitHub Check: E2E Service Test (Realtime)
- GitHub Check: E2E Service Test (Databases)
- GitHub Check: E2E Service Test (GraphQL)
- GitHub Check: E2E Service Test (Locale)
- GitHub Check: E2E Service Test (Avatars)
- GitHub Check: E2E Service Test (Site Screenshots)
- GitHub Check: E2E Service Test (Dev Keys)
- GitHub Check: E2E General Test
- GitHub Check: Unit Test
- GitHub Check: Benchmark
@@ -60,7 +60,7 @@ | |||
[ | |||
'key' => 'flutter', | |||
'name' => 'Flutter', | |||
'version' => '17.1.0', | |||
'version' => '17.1.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Flutter SDK version bump looks good; please verify pub.dev release and docs entry
All references for Flutter remain consistent; only the version string changed. To avoid config pointing to an unpublished version, verify pub.dev shows 17.1.1 and that the docs changelog includes an entry for it.
Run this script:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
expected_flutter="17.1.1"
echo "Checking pub.dev for Flutter package 'appwrite'..."
actual_flutter="$(curl -s https://pub.dev/api/packages/appwrite | jq -r '.latest.version')"
echo "pub.dev latest: $actual_flutter"
if [[ "$actual_flutter" != "$expected_flutter" ]]; then
echo "Mismatch: expected $expected_flutter, got $actual_flutter"
exit 1
fi
echo "OK: Flutter version matches $expected_flutter"
# Optional: verify docs changelog contains the version header (path derived from this file)
if [[ -f docs/sdks/flutter/CHANGELOG.md ]]; then
if rg -nP "^\s*##\s*$expected_flutter\b" docs/sdks/flutter/CHANGELOG.md > /dev/null; then
echo "OK: docs/sdks/flutter/CHANGELOG.md has entry for $expected_flutter"
else
echo "WARN: docs/sdks/flutter/CHANGELOG.md missing entry for $expected_flutter"
exit 2
fi
else
echo "NOTE: docs/sdks/flutter/CHANGELOG.md not present in this repo checkout."
fi
Length of output: 440
Flutter SDK version 17.1.1 not published on pub.dev
The bump in app/config/platforms.php (line 63) points to 17.1.1, but pub.dev’s latest for the Appwrite Flutter package is still 17.1.0. Please:
- Confirm that version 17.1.1 is published on pub.dev (currently shows 17.1.0).
- If it isn’t yet released, revert this bump or delay merging until the new version is live.
- Once 17.1.1 is published, add a “## 17.1.1” entry to docs/sdks/flutter/CHANGELOG.md.
🤖 Prompt for AI Agents
In app/config/platforms.php around line 63, the Flutter SDK version was bumped
to '17.1.1' but pub.dev currently lists 17.1.0; confirm whether 17.1.1 is
published on pub.dev, and if it is not, revert the change back to 17.1.0 or hold
merging until 17.1.1 is live; after the package is published, update this file
to 17.1.1 (if reverted) and add a "## 17.1.1" entry to
docs/sdks/flutter/CHANGELOG.md documenting the release.
@@ -394,7 +394,7 @@ | |||
[ | |||
'key' => 'dart', | |||
'name' => 'Dart', | |||
'version' => '16.2.0', | |||
'version' => '16.2.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Dart server SDK version bump looks good; please verify pub.dev release and docs entry
The server-side Dart entry is updated as intended. Confirm the package is published at 16.2.1 and that the docs changelog reflects it.
Run this script:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
expected_dart="16.2.1"
echo "Checking pub.dev for Dart server package 'dart_appwrite'..."
actual_dart="$(curl -s https://pub.dev/api/packages/dart_appwrite | jq -r '.latest.version')"
echo "pub.dev latest: $actual_dart"
if [[ "$actual_dart" != "$expected_dart" ]]; then
echo "Mismatch: expected $expected_dart, got $actual_dart"
exit 1
fi
echo "OK: Dart server version matches $expected_dart"
# Optional: verify docs changelog contains the version header (path derived from this file)
if [[ -f docs/sdks/dart/CHANGELOG.md ]]; then
if rg -nP "^\s*##\s*$expected_dart\b" docs/sdks/dart/CHANGELOG.md > /dev/null; then
echo "OK: docs/sdks/dart/CHANGELOG.md has entry for $expected_dart"
else
echo "WARN: docs/sdks/dart/CHANGELOG.md missing entry for $expected_dart"
exit 2
fi
else
echo "NOTE: docs/sdks/dart/CHANGELOG.md not present in this repo checkout."
fi
Length of output: 457
Dart SDK version bump requires pub.dev release & docs entry
The change updates the Dart server SDK to 16.2.1, but pub.dev still lists 16.2.0. You’ll need to:
• Publish version 16.2.1 of dart_appwrite
to pub.dev
• Add a “## 16.2.1” entry in docs/sdks/dart/CHANGELOG.md
Once both are done, we can approve the version bump.
🤖 Prompt for AI Agents
In app/config/platforms.php around line 397 the Dart SDK version was bumped to
'16.2.1' but pub.dev still hosts 16.2.0 and the docs lack a changelog entry;
publish the new dart_appwrite 16.2.1 package to pub.dev and add a "## 16.2.1"
section with the appropriate release notes to docs/sdks/dart/CHANGELOG.md
(ensure the entry matches the version bump and include any notable changes),
then verify pub.dev shows 16.2.1 before marking the PR ready.
✨ Benchmark results
⚡ Benchmark Comparison
|
What does this PR do?
Test Plan
None
Related PRs and Issues
SDK generator PRs
Updating Flutter:
Checklist