app/config/locale/translations/de.json (3)

53-55: German greeting in invitation email is in English

"Hello," should be "Hallo,".

Apply:

-    "emails.invitation.hello": "Hello,",
+    "emails.invitation.hello": "Hallo,",

---

84-86: Typo: “Brazilen” → “Brasilien”

Correct the country name spelling.

-    "countries.br": "Brazilen",
+    "countries.br": "Brasilien",

---

147-149: Country name in German

Use “Jordanien” instead of “Jordan”.

-    "countries.jo": "Jordan",
+    "countries.jo": "Jordanien",

app/config/locale/translations/he.json (3)

46-46: Spelling and word order: “סיסמא/סיסמה” and phrasing

Use the normative spelling “סיסמה” and fix button text order to “איפוס סיסמה”.

-    "emails.recovery.subject": "איפוס סיסמא",
+    "emails.recovery.subject": "איפוס סיסמה",

-    "emails.recovery.buttonText": "סיסמא איפוס",
+    "emails.recovery.buttonText": "איפוס סיסמה",

Also applies to: 51-51

---

91-91: Misspelling: Switzerland

Preferred spelling is “שווייץ”.

-    "countries.ch": "שוויץ",
+    "countries.ch": "שווייץ",

---

1-278: Fix missing placeholders in he.json and de.json

I ran a placeholder comparison against en.json — there are 5 placeholder mismatches in each of the Hebrew and German files. Please restore the missing moustache placeholders (exactly as in en.json).

Files / keys to fix:

• app/config/locale/translations/he.json and app/config/locale/translations/de.json
  • emails.invitation.hello — expected {{user}} (missing)
  • emails.magicSession.hello — expected {{user}} (missing)
  • emails.magicSession.subject — expected {{project}} (missing)
  • emails.otpSession.hello — expected {{user}} (missing)
  • emails.verification.body — expected {{project}} (missing)

Action: update the translations to include the exact placeholders from en.json (including braces), then re-run the placeholder-check script to confirm no mismatches remain.

app/config/locale/translations/nl.json (2)

267-275: Inconsistent placeholder formatting: missing {{b}}...{{/b}} wrappers

Other locales and related keys (e.g., emails.mfaChallenge.clientInfo) use {{b}} wrappers to bold dynamic values. These two lines lack them, leading to inconsistent markup in emails.

Apply this diff:

-    "emails.magicSession.clientInfo": "Deze aanmelding is aangevraagd met {{agentClient}} op {{agentDevice}} {{agentOs}}. Als u de aanmelding niet heeft aangevraagd, kunt u deze e-mail gerust negeren.",
+    "emails.magicSession.clientInfo": "Deze aanmelding is aangevraagd met {{b}}{{agentClient}}{{/b}} op {{b}}{{agentDevice}}{{/b}} {{b}}{{agentOs}}{{/b}}. Als u de aanmelding niet heeft aangevraagd, kunt u deze e-mail gerust negeren.",
@@
-    "emails.otpSession.clientInfo": "Deze aanmelding is aangevraagd met {{agentClient}} op {{agentDevice}} {{agentOs}}. Als u de aanmelding niet heeft aangevraagd, kunt u deze e-mail veilig negeren.",
+    "emails.otpSession.clientInfo": "Deze aanmelding is aangevraagd met {{b}}{{agentClient}}{{/b}} op {{b}}{{agentDevice}}{{/b}} {{b}}{{agentOs}}{{/b}}. Als u de aanmelding niet heeft aangevraagd, kunt u deze e-mail veilig negeren.",

---

100-110: Fix Dutch country names in app/config/locale/translations/nl.json

Several country names are in English or have spelling/formatting issues. Verified keys and recommended corrections:

• countries.cv: "Cape Verde" -> "Kaapverdië"
• countries.do: "Dominican Republic" -> "Dominicaanse Republiek"
• countries.gq: "Equatorial Guinea" -> "Equatoriaal-Guinea"
• countries.hr: "Croatië" -> "Kroatië"
• countries.il: "Israel" -> "Israël"
• countries.kh: "Cambodia" -> "Cambodja"
• countries.kr: "Zuid Korea" -> "Zuid-Korea"
• countries.kp: "Noord Korea" -> "Noord-Korea"
• countries.ly: "Libya" -> "Libië"
• countries.ss: "Zuid Soedan" -> "Zuid-Soedan"
• countries.se: "Sweden" -> "Zweden"
• countries.tr: "Turkijë" -> "Turkije"

Proposed diff:

-    "countries.cv": "Cape Verde",
+    "countries.cv": "Kaapverdië",
-    "countries.do": "Dominican Republic",
+    "countries.do": "Dominicaanse Republiek",
-    "countries.gq": "Equatorial Guinea",
+    "countries.gq": "Equatoriaal-Guinea",
-    "countries.hr": "Croatië",
+    "countries.hr": "Kroatië",
-    "countries.il": "Israel",
+    "countries.il": "Israël",
-    "countries.kh": "Cambodia",
+    "countries.kh": "Cambodja",
-    "countries.kr": "Zuid Korea",
+    "countries.kr": "Zuid-Korea",
-    "countries.kp": "Noord Korea",
+    "countries.kp": "Noord-Korea",
-    "countries.ly": "Libya",
+    "countries.ly": "Libië",
-    "countries.ss": "Zuid Soedan",
+    "countries.ss": "Zuid-Soedan",
-    "countries.se": "Sweden",
+    "countries.se": "Zweden",
-    "countries.tr": "Turkijë",
+    "countries.tr": "Turkije",

I can run a consistency check across all locale files to ensure translations are uniform if you want.

app/config/locale/translations/pt-pt.json (1)

104-105: PT-PT translations — replace PT-BR spellings with European Portuguese forms

Verified (Priberam / EU / MNE-PT): use Chéquia, Irão, Roménia, São Vicente.

Files/locations to change:

• app/config/locale/translations/pt-pt.json — lines 104 (countries.cz), 141 (countries.ir), 208 (countries.ro), 249 (countries.vc)

Suggested diff:

-    "countries.cz": "Tchéquia",
+    "countries.cz": "Chéquia",
-    "countries.ir": "Irã",
+    "countries.ir": "Irão",
-    "countries.ro": "Romênia",
+    "countries.ro": "Roménia",
-    "countries.vc": "São Vincente e Granadinas",
+    "countries.vc": "São Vicente e Granadinas",

app/config/locale/translations/ne.json (4)

266-266: French text in Nepali locale: magicSession.buttonText

The button label is in French.

-    "emails.magicSession.buttonText": "Connectez-vous à {{project}}",
+    "emails.magicSession.buttonText": "{{project}} मा साइन इन गर्नुहोस्",

---

35-35: Inconsistent “sender/signature” nouns across emails (समूह / टोली / टिम)

Use one consistent term across the file. Early lines use “टोली”; adopt that everywhere for consistency.

-    "emails.sender": "%s समूह",
+    "emails.sender": "%s टोली",
-    "emails.verification.signature": "{{project}} समूह",
+    "emails.verification.signature": "{{project}} टोली",
-    "emails.magicSession.signature": "{{project}} समूह",
+    "emails.magicSession.signature": "{{project}} टोली",
-    "emails.recovery.signature": "{{project}} समूह",
+    "emails.recovery.signature": "{{project}} टोली",
-    "emails.invitation.signature": "{{project}} समूह",
+    "emails.invitation.signature": "{{project}} टोली",
-    "emails.otpSession.signature": "{{project}} टिम"
+    "emails.otpSession.signature": "{{project}} टोली"

Also applies to: 41-41, 45-45, 52-52, 59-59, 277-277

---

97-97: Incorrect country names/transliterations for several ISO codes

These will surface incorrect UI labels. Suggested corrections:

-    "countries.cd": "दि आर कांगो",
+    "countries.cd": "डीआर कंगो",
-    "countries.ga": "गेबन",
+    "countries.ga": "गाबोन",
-    "countries.gn": "गुयना",
+    "countries.gn": "गिनी",
-    "countries.gw": "गुयना-बिसाउ",
+    "countries.gw": "गिनी-बिसाउ",
-    "countries.gq": "इक्वेटोरियल गुयना",
+    "countries.gq": "इक्वेटोरियल गिनी",
-    "countries.mc": "मोरक्को",
+    "countries.mc": "मोनाको",
-    "countries.pg": "पापुआ न्यू गुयना",
+    "countries.pg": "पापुआ न्यु गिनी",
-    "countries.us": "युनाइटेड अमेरिका",
+    "countries.us": "संयुक्त राज्य अमेरिका",

If you want, I can cross-check the full country list against authoritative Nepali names and supply a complete patch.

Also applies to: 122-122, 125-125, 128-129, 170-170, 203-203, 246-246

---

268-268: Add a short label to SMS verification messages in en.json and ne.json

Bare "{{secret}}" provides poor UX and can trigger anti‑spam heuristics — make the SMS a short labelled sentence and keep locales consistent. Confirm final copy with product and SMS length constraints.

Files to update:

• app/config/locale/translations/en.json — line ~72
• app/config/locale/translations/ne.json — line ~268

Suggested diffs:

app/config/locale/translations/en.json

-    "sms.verification.body": "{{secret}}",
+    "sms.verification.body": "Your verification code: {{secret}}",

app/config/locale/translations/ne.json

-    "sms.verification.body": "{{secret}}",
+    "sms.verification.body": "तपाईंको प्रमाणिकरण कोड: {{secret}}",

Please adjust the exact phrasing to match product copy and SMS character limits.

app/config/locale/translations/de.json (4)

227-228: Outdated country name: Swasiland → Eswatini

Modern name is “Eswatini”.

-    "countries.sz": "Swasiland",
+    "countries.sz": "Eswatini",

---

26-26: Trailing space in greeting

Trailing whitespace in localized strings can look odd in UI.

-    "emails.sessionAlert.hello": "Hallo {{user}}, ",
+    "emails.sessionAlert.hello": "Hallo {{user}},",

---

2-2: Unify “Team” signature style

File mixes “{{project}} Team” and “{{project}}-Team”. Align to one style (rest of file largely uses “-Team”).

-    "emails.certificate.signature": "{{project}} Team",
+    "emails.certificate.signature": "{{project}}-Team",

-    "emails.mfaChallenge.signature": "{{project}} Team",
+    "emails.mfaChallenge.signature": "{{project}}-Team",

-    "emails.sessionAlert.signature": "{{project}} Team",
+    "emails.sessionAlert.signature": "{{project}}-Team",

-    "emails.otpSession.signature": "{{project}} Team",
+    "emails.otpSession.signature": "{{project}}-Team",

Also applies to: 11-11, 19-19, 277-277

---

278-279: Confirm the “mock” key is intentional

"mock" looks like a test stub. If unused in production, consider removing to avoid shipping dead keys.

I can scan for references to the "mock" key across the repo and open a cleanup PR if it’s unused.

app/config/locale/translations/he.json (2)

12-12: Unnatural phrasing for thanks

Prefer common "תודה," over "מודה לך,".

-    "emails.mfaChallenge.thanks": "מודה לך,",
+    "emails.mfaChallenge.thanks": "תודה,",

---

17-17: Inconsistent punctuation in subject

Avoid trailing period in subject for consistency with other locales.

-    "emails.mfaChallenge.subject": "קוד האימות עבור {{project}}.",
+    "emails.mfaChallenge.subject": "קוד האימות עבור {{project}}",

src/Appwrite/Platform/Tasks/DevGenerateTranslations.php (2)

31-36: Parameter typing and dry-run parsing

Param uses Boolean validator, but action receives mixed and then checks only for string 'true'. Support common truthy inputs and type to bool locally.

-    public function action(mixed $dryRun, string $apiKey): void
+    public function action(mixed $dryRun, string $apiKey): void
     {
-        $dryRun = \strval($dryRun) === 'true';
+        $value = \strtolower(\strval($dryRun));
+        $dryRun = \in_array($value, ['1', 'true', 'on', 'yes'], true);

Also applies to: 38-46

---

83-94: Locale language hint can be ambiguous (e.g., pt-br vs pt-pt)

Passing “pt-br”/“pt-pt” raw in the prompt may degrade quality. Map to human-friendly hints like “Portuguese (Brazil)” and “Portuguese (Portugal)”.

I can add a simple mapping:

• pt-br => Portuguese (Brazil)
• pt-pt => Portuguese (Portugal)
• zh-cn/zh-tw, etc.

Want me to push a patch with a small locale-to-language map?

app/config/locale/translations/nl.json (2)

37-38: Typo: “verifieren” → “verifiëren”

Correct Dutch spelling with trema.

-    "emails.verification.body": "Volg deze link om uw e-mail te verifieren",
+    "emails.verification.body": "Volg deze link om uw e-mail te verifiëren",

---

55-56: Typos in invitation email

Fix past participle and diacritics.

-    "emails.invitation.body": "U ontvangt deze mail want u was uitgenodig door {{owner}} om lid van het {{team}} team te worden in {{project}} ",
-    "emails.invitation.footer": "Als u niet geintereseerd bent, kan u deze mail negeren.",
+    "emails.invitation.body": "U ontvangt deze mail omdat u bent uitgenodigd door {{owner}} om lid van het {{team}}-team te worden in {{project}}.",
+    "emails.invitation.footer": "Als u niet geïnteresseerd bent, kunt u deze mail negeren.",

app/config/locale/translations/pt-pt.json (4)

36-37: Greeting tone is not PT-PT

“Hey” is informal/English. Prefer “Olá”.

-    "emails.verification.hello": "Hey {{user}},",
+    "emails.verification.hello": "Olá {{user}},",

---

43-45: Trailing space after greeting

Minor cleanup.

-    "emails.magicSession.hello": "Olá ,",
+    "emails.magicSession.hello": "Olá,",

---

15-16: Superfluous newline in hello

Remove the newline escape.

-    "emails.mfaChallenge.hello": "Olá {{user}}, \n",
+    "emails.mfaChallenge.hello": "Olá {{user}},",

---

267-275: Add bold wrappers to match other templates

For consistency with mfaChallenge.clientInfo, wrap dynamic parts with {{b}} tags.

-    "emails.magicSession.clientInfo": "Este início de sessão foi solicitado usando o {{agentClient}} no {{agentDevice}} {{agentOs}}. Se não foi você quem solicitou o início de sessão, pode ignorar este e-mail com segurança.",
+    "emails.magicSession.clientInfo": "Este início de sessão foi solicitado usando o {{b}}{{agentClient}}{{/b}} no {{b}}{{agentDevice}}{{/b}} {{b}}{{agentOs}}{{/b}}. Se não foi você quem solicitou o início de sessão, pode ignorar este e-mail com segurança.",

app/config/locale/translations/pt-br.json (3)

26-27: Trailing space after greeting

Minor cleanup.

-    "emails.sessionAlert.hello": "Olá {{user}}, ",
+    "emails.sessionAlert.hello": "Olá {{user}},",

---

267-275: Normalize clientInfo placeholders to include bold wrappers

Keep formatting consistent across templates.

-    "emails.magicSession.clientInfo": "Este acesso foi solicitado usando {{agentClient}} em {{agentDevice}} {{agentOs}}. Se você não solicitou o acesso, pode ignorar este e-mail com segurança.",
+    "emails.magicSession.clientInfo": "Este acesso foi solicitado usando {{b}}{{agentClient}}{{/b}} em {{b}}{{agentDevice}}{{/b}} {{b}}{{agentOs}}{{/b}}. Se você não solicitou o acesso, pode ignorar este e-mail com segurança.",
@@
-    "emails.otpSession.clientInfo": "Este acesso foi solicitado usando {{agentClient}} em {{agentDevice}} {{agentOs}}. Se você não solicitou o acesso, pode ignorar este e-mail com segurança.",
+    "emails.otpSession.clientInfo": "Este acesso foi solicitado usando {{b}}{{agentClient}}{{/b}} em {{b}}{{agentDevice}}{{/b}} {{b}}{{agentOs}}{{/b}}. Se você não solicitou o acesso, pode ignorar este e-mail com segurança.",

---

276-277: Signature inconsistent with the rest of PT-BR (“Time” vs “equipe”)

Elsewhere you use “Time {{project}}”. Align this here.

-    "emails.otpSession.signature": "equipe {{project}}"
+    "emails.otpSession.signature": "Time {{project}}"

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

src/Appwrite/Platform/Tasks/DevGenerateTranslations.php (5)

54-58: Add JSON read/parse checks and limit to .json files only

Reading/parsing en.json without checks and scanning the dir without filtering risks crashes on malformed files and processing non-JSON files.

-        $mainJson = \json_decode(\file_get_contents($dir . '/' . $mainFile), true);
-        $mainKeys = \array_keys($mainJson);
-
-        $files = \array_diff(\scandir($dir), array('.', '..', $mainFile));
+        $mainPath = $dir . '/' . $mainFile;
+        $mainContent = @\file_get_contents($mainPath);
+        if ($mainContent === false) {
+            Console::error("Failed to read {$mainFile} at {$mainPath}.");
+            return;
+        }
+        $mainJson = \json_decode($mainContent, true);
+        if (!\is_array($mainJson)) {
+            Console::error("Failed to parse {$mainFile} as JSON: " . \json_last_error_msg());
+            return;
+        }
+        $mainKeys = \array_keys($mainJson);
+        // Only process locale JSON files (exclude en.json itself)
+        $files = \array_values(\array_filter(\scandir($dir), function ($f) use ($mainFile, $dir) {
+            return $f !== '.' && $f !== '..' && $f !== $mainFile && \str_ends_with($f, '.json') && \is_file($dir . '/' . $f);
+        }));
+        // Ensure enforced keys exist in English source
+        $enforcedKeys = \array_values(\array_intersect($enforcedKeys, $mainKeys));

---

62-68: Guard per-locale JSON reads against unreadable/malformed files

array_keys() on null will emit warnings if JSON is invalid; also protect file reads.

-            $fileJson = \json_decode(\file_get_contents($dir . '/' . $file), true);
-            $fileKeys = \array_keys($fileJson);
+            $filePath = $dir . '/' . $file;
+            $fileContent = @\file_get_contents($filePath);
+            if ($fileContent === false) {
+                Console::warning("Failed to read {$file}; skipping.");
+                continue;
+            }
+            $fileJson = \json_decode($fileContent, true);
+            if (!\is_array($fileJson)) {
+                Console::warning("Skipping {$file}: invalid JSON: " . \json_last_error_msg());
+                continue;
+            }
+            $fileKeys = \array_keys($fileJson);

---

87-111: Avoid N×I/O: load locale once, translate all, write once

Currently the file is re-read and re-written per missing key. Read once, mutate in memory, and write once with error checks.

-                    $language = \explode('.', $file)[0];
-
-                    foreach ($missingKeys as $missingKey) {
-                        $json = \json_decode(\file_get_contents($dir . '/' . $file), true);
-
-                        $translation = $this->generateTranslation($language, $mainJson[$missingKey], $apiKey);
-
-                        Console::log('Translation results:');
-                        Console::log('English: ' . $mainJson[$missingKey]);
-                        Console::log($language . ': ' . $translation);
-
-                        $keysProcessed++;
-
-                        // This puts new key at beginning to prevent merge conflict issue and ending comma
-                        $newPair = [];
-                        $newPair[$missingKey] = $translation;
-
-                        if (isset($json[$missingKey])) {
-                            unset($json[$missingKey]);
-                        }
-
-                        $json = \array_merge($newPair, $json);
-
-                        \file_put_contents($dir . '/' . $file, \json_encode($json, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES | 0));
-                    }
+                    $language = \explode('.', $file)[0];
+                    // Work on the already-decoded $fileJson
+                    $json = $fileJson;
+                    $newPairs = [];
+                    foreach ($missingKeys as $missingKey) {
+                        if (!\array_key_exists($missingKey, $mainJson)) {
+                            Console::warning("Skipping {$missingKey}: not found in English source.");
+                            continue;
+                        }
+                        $translation = $this->generateTranslation($language, $mainJson[$missingKey], $apiKey);
+                        Console::log('Translation results:');
+                        Console::log('English: ' . $mainJson[$missingKey]);
+                        Console::log($language . ': ' . $translation);
+                        $keysProcessed++;
+                        if (isset($json[$missingKey])) {
+                            unset($json[$missingKey]); // avoid duplicates
+                        }
+                        $newPairs[$missingKey] = $translation; // collect to prepend later
+                    }
+                    if (!empty($newPairs)) {
+                        // Prepend all new pairs at once
+                        $json = \array_merge($newPairs, $json);
+                        $bytes = \file_put_contents(
+                            $filePath,
+                            \json_encode($json, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES)
+                        );
+                        if ($bytes === false) {
+                            Console::error("Failed writing {$file}");
+                        }
+                    }

---

124-133: Harden placeholder protection: support closing tags and printf tokens

The current regex only matches {{word}}. Protect {{/tag}}, dotted tokens, and printf-like placeholders to avoid corrupting templates.

-        $id = 0;
-        $pattern = '/{{\w+}}/';
-
-        $enTranslation = preg_replace_callback($pattern, function ($match) use (&$id, &$placeholders) {
-            $placeholders[$id] = $match[0];
-            $label = \trim($match[0], "{}");
-            $key = "<m id={$id} label=\"{$label}\" />";
-            $id++;
-            return $key;
-        }, $enTranslation);
+        $id = 0;
+        // Protect: {{tag}}, {{/tag}}, {{token.with.dots}}, and common printf tokens (%s, %d, %f, %u, and positional)
+        $pattern = '/{{\/?[\w\.]+}}|%(\d+\$)?[sduf]/';
+
+        $enTranslation = \preg_replace_callback($pattern, function ($match) use (&$id, &$placeholders) {
+            $placeholders[$id] = $match[0];
+            // Keep label simple and safe
+            $label = \str_replace('"', '&quot;', $match[0]);
+            $key = "<m id={$id} label=\"{$label}\" />";
+            $id++;
+            return $key;
+        }, $enTranslation);

---

160-165: Validate LLM output and provide safe fallback restoring placeholders

Assuming a well-formed JSON with a 'translation' field is brittle. Add guards and fallback to the original text with placeholders restored.

-        $output = $conversation->send()->getContent();
-
-        $outputJson = \json_decode($output, true);
-
-        $targetTranslation = $outputJson['translation'];
+        $output = $conversation->send()->getContent();
+        $outputJson = \json_decode($output, true);
+        if (!\is_array($outputJson) || !\array_key_exists('translation', $outputJson) || !\is_string($outputJson['translation'])) {
+            Console::warning('LLM returned unexpected payload, falling back to original text.');
+            // Restore placeholders in the original English string before returning
+            $id = 0;
+            $fallback = $enTranslation;
+            foreach ($placeholders as $placeholder) {
+                $pattern = '/\<m id=' . $id . ' label=".+" \/>/';
+                $fallback = \preg_replace($pattern, $placeholder, $fallback);
+                $id++;
+            }
+            return $fallback;
+        }
+        $targetTranslation = $outputJson['translation'];

src/Appwrite/Platform/Tasks/DevGenerateTranslations.php (2)

110-110: Nit: remove superfluous bitwise OR flag

| 0 is a no-op in json_encode options.

-                        \file_put_contents($dir . '/' . $file, \json_encode($json, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES | 0));
+                        \file_put_contents($dir . '/' . $file, \json_encode($json, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES));

---

78-86: Optional: batch logging and rate-limit to avoid noisy output

When many keys are missing, per-key logs can flood output and slow runs. Consider batching summaries or a --verbose toggle.

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.