Enforce operations cap per transaction #10319

abnegate · 2025-08-14T09:51:04Z

What does this PR do?

This PR enforces a per-transaction operations cap across all database operations that stage transactions. This ensures consistency with the existing AddOperations behavior, preventing a single transaction from exceeding the defined operation limit.

The enforcement logic is applied to:

Document operations: Create, Update, Delete, Upsert
Bulk document operations: Bulk/Delete, Bulk/Update, Bulk/Upsert
Attribute operations: Attribute/Increment, Attribute/Decrement

For each affected operation, the plan parameter is injected (if not already present), and a check is performed before staging the operation to ensure the transaction's operation count does not exceed databasesBatchSize (or APP_LIMIT_DATABASE_BATCH by default).

Test Plan

Configure Transaction Limits: Ensure APP_LIMIT_DATABASE_BATCH is set to a small number (e.g., 1 or 2) in your .env file for easier testing.
Initiate a Transaction: Start a database transaction using the relevant API endpoint (e.g., POST /databases/{databaseId}/transactions). Note the transactionId.
Perform a Single Operation:
- Attempt to Create, Update, Delete, Upsert a single document, or Increment/Decrement an attribute within the transaction.
- Verify the operation succeeds if it's the first operation in the transaction and APP_LIMIT_DATABASE_BATCH is 1 or more.
- Attempt a second single operation within the same transaction.
- Verify that it fails with Exception::TRANSACTION_LIMIT_EXCEEDED if APP_LIMIT_DATABASE_BATCH is 1.
Perform a Bulk Operation:
- Start a new transaction.
- Attempt a Bulk/Create, Bulk/Update, or Bulk/Upsert operation with multiple documents (e.g., 2 documents).
- Verify that it fails with Exception::TRANSACTION_LIMIT_EXCEEDED if APP_LIMIT_DATABASE_BATCH is 1.
- Verify it succeeds if APP_LIMIT_DATABASE_BATCH is set to a value greater than or equal to the number of documents in the bulk operation.

Related PRs and Issues

(Related PR or issue)

Checklist

Have you read the Contributing Guidelines on issues?
If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Update migrations

Add placeholder detection

…oker Feat: Make functions worker customizable

Co-authored-by: jakeb994 <jakeb994@gmail.com>

…mmand Update build command for flutter

Skip redundant subqueries in users list route

…ache-clearing-bug-2799 Fix databases worker cache clearing bug

…e-function-broker Revert "Feat: Make functions worker customizable"

This reverts commit 7e110bf.

Feat: Redis functions queue (reapply with fixes)

…ate-required-attributes # Conflicts: # composer.json # composer.lock

…ate-required-attributes

Update package

Update required attributes

…rnings chore: remove experiment warnings from bulk methods

# Conflicts: # app/config/specs/open-api3-latest-client.json # app/config/specs/open-api3-latest-console.json # app/config/specs/open-api3-latest-server.json # app/config/specs/swagger2-latest-client.json # app/config/specs/swagger2-latest-console.json # app/config/specs/swagger2-latest-server.json # app/controllers/api/databases.php # composer.lock # src/Appwrite/SDK/Specification/Format/OpenAPI3.php

Co-authored-by: jakeb994 <jakeb994@gmail.com>

cursor · 2025-08-14T09:51:06Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

coderabbitai · 2025-08-14T09:51:11Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)

main
1.6.x
1.7.x
1.8.x

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch cursor/enforce-operations-cap-per-transaction-6dd5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-08-14T09:53:29Z

Security Scan Results for PR

Docker Image Scan Results

Package	Version	Vulnerability	Severity
golang.org/x/crypto	v0.31.0	CVE-2025-22869	HIGH
golang.org/x/oauth2	v0.24.0	CVE-2025-22868	HIGH
stdlib	1.22.10	CVE-2025-47907	HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

github-actions · 2025-08-14T10:02:29Z

✨ Benchmark results

Requests per second: 20,146
Requests with 200 status code: n,ull
P99 latency: 0.007219764

⚡ Benchmark Comparison

Metric	This PR	Latest version
RPS	20,146	961
200	n,ull	173,082
P99	0.007219764	0.199445658

…operations Co-authored-by: jakeb994 <jakeb994@gmail.com>

...rite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Decrement.php

… actions Co-authored-by: jakeb994 <jakeb994@gmail.com>

…ction-6dd5

abnegate and others added 30 commits August 8, 2025 23:45

Update migrations

10254c5

Add placeholder detection

ae5225d

Fix formatting

1fba63e

Fix tests

96b7f31

Merge pull request #10283 from appwrite/fix-csv-import

eb3caea

Update migrations

Merge pull request #10284 from appwrite/temp-add-placeholder-detection

f430622

Add placeholder detection

Make functions worker customizable

2b3a852

Fix typo

9a6c4c5

Merge pull request #10287 from appwrite/feat-customizable-function-br…

3510b9d

…oker Feat: Make functions worker customizable

Update build command for flutter

913fa9d

Purge collection cache alongside document cache in database operations

b89d713

Co-authored-by: jakeb994 <jakeb994@gmail.com>

Add database query tests for notContains, notSearch, and other filters

acaea49

Co-authored-by: jakeb994 <jakeb994@gmail.com>

Skip redundant subqueries in users list route

7a0b344

Bump flutter starter version

4da9b99

Update DB

672f642

Merge pull request #10288 from appwrite/chore-update-flutter-build-co…

334c147

…mmand Update build command for flutter

Merge pull request #10297 from appwrite/feat-skip-user-subqueries

a8cc01d

Skip redundant subqueries in users list route

Merge pull request #10294 from appwrite/cursor/fix-databases-worker-c…

12d0853

…ache-clearing-bug-2799 Fix databases worker cache clearing bug

Revert "Feat: Make functions worker customizable"

7e110bf

Fix merge

5cec34b

Merge pull request #10298 from appwrite/revert-10287-feat-customizabl…

ec174a1

…e-function-broker Revert "Feat: Make functions worker customizable"

Fix missing place not using proper publisher

ee13066

Reapply "Feat: Make functions worker customizable"

3efd9a7

This reverts commit 7e110bf.

Linter fix

b641c9e

Fix flakyness

100ab4e

Fix notSearch with no FTS

836606a

Update tests

a7ccb7b

Fix index count tests

22d58e7

Fix not search on wrong attribute

0febefc

Merge pull request #10299 from appwrite/feat-functions-redis-queue

f81fd16

Feat: Redis functions queue (reapply with fixes)

abnegate and others added 16 commits August 13, 2025 21:16

Update versions

c86210e

chore: add method desc and demo

5f3dc7c

Update audit lib & platform

2c1655e

Update svg-sanitizer

27bb70b

Update package

72253f3

Merge branch '1.8.x' of https://github.com/appwrite/appwrite into upd…

4f52907

…ate-required-attributes # Conflicts: # composer.json # composer.lock

revert lock

83d76c5

Merge branch '1.8.x' of https://github.com/appwrite/appwrite into upd…

fb87541

…ate-required-attributes

Merge pull request #10312 from appwrite/chore-update-dep

8beb80d

Update package

Merge pull request #10311 from appwrite/update-required-attributes

420783d

Update required attributes

update specs

9860cd4

Merge pull request #10310 from appwrite/update-remove-experimental-wa…

6a3ea1f

…rnings chore: remove experiment warnings from bulk methods

Port desc fixes

ff6c2b0

Merge remote-tracking branch 'origin/1.8.x' into feat-txn

1da2812

Enforce max operations per transaction in database operations

6d47768

Co-authored-by: jakeb994 <jakeb994@gmail.com>

Replace databasesBatchSize with databasesTransactionSize in database …

dffe030

…operations Co-authored-by: jakeb994 <jakeb994@gmail.com>

abnegate commented Aug 14, 2025

View reviewed changes

...rite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Decrement.php Outdated Show resolved Hide resolved

cursoragent and others added 5 commits August 14, 2025 10:17

Remove unused function and webhook event queue injections in database…

335052b

… actions Co-authored-by: jakeb994 <jakeb994@gmail.com>

Import fixes

31a7df7

Merge branch 'feat-txn' of github.com:appwrite/appwrite into feat-txn

ba25f9f

Merge branch 'feat-txn' into cursor/enforce-operations-cap-per-transa…

ef63d42

…ction-6dd5

Fix create inject

c8afcbc

abnegate marked this pull request as ready for review August 14, 2025 10:22

abnegate merged commit 2dd8dd8 into feat-txn Aug 14, 2025
8 of 9 checks passed

abnegate deleted the cursor/enforce-operations-cap-per-transaction-6dd5 branch August 14, 2025 10:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enforce operations cap per transaction #10319

Enforce operations cap per transaction #10319

Uh oh!

abnegate commented Aug 14, 2025

Uh oh!

cursor bot commented Aug 14, 2025

Uh oh!

coderabbitai bot commented Aug 14, 2025 •

edited

Loading

Other AI code review bot(s) detected

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

github-actions bot commented Aug 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Enforce operations cap per transaction #10319

Enforce operations cap per transaction #10319

Uh oh!

Conversation

abnegate commented Aug 14, 2025

What does this PR do?

Test Plan

Related PRs and Issues

Checklist

Uh oh!

cursor bot commented Aug 14, 2025

Uh oh!

coderabbitai bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

github-actions bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Scan Results for PR

Docker Image Scan Results

Source Code Scan Results

Uh oh!

github-actions bot commented Aug 14, 2025

✨ Benchmark results

⚡ Benchmark Comparison

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Aug 14, 2025 •

edited

Loading

github-actions bot commented Aug 14, 2025 •

edited

Loading