-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Remove obsolete doc for flutter #10211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.7.x
Are you sure you want to change the base?
Conversation
…-to-start docs: update CONTRIBUTING.md to clarify how to start
📝 WalkthroughWalkthroughThe "How to Start?" section of the CONTRIBUTING.md file was completely rewritten to provide a detailed, step-by-step guide for new contributors. The new version introduces a structured three-step process for finding issues, requesting assignment, and submitting pull requests, with additional instructions to coordinate via Discord. A "Please Note" section was added to clarify team size and the necessity of following the outlined process. No other documentation or code was modified. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
CONTRIBUTING.md (3)
20-27
: Consider mentioning GitHub’s self-assignment shortcut
Many orgs enable “Assign yourself” or the/assign
slash-command. Pointing contributors to that option could remove a round-trip and reduce lag if maintainers forget to assign manually.
28-32
: Tone tweak for Step 3 title & wording
“Random PRs” reads a bit informal and can be perceived as dismissive. A neutral phrasing still conveys the policy while keeping the voice professional.-### 💬 Step 3: Don’t Submit Random PRs +### 💬 Step 3: Submit PRs Only for Assigned Issues @@ -PRs submitted without context or discussion may not align with our roadmap and may be closed without review. +Pull requests opened without prior discussion or an associated issue may not align with our roadmap and could be closed without review.
34-36
: Remove over-used intensifier
Minor wording polish—dropping “very” tightens the sentence and addresses the LanguageTool hint.-We’re a very small team managing a large project. +We’re a small team managing a large project.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
docs/sdks/flutter-dev/CHANGELOG.md
is excluded by!docs/sdks/**
docs/sdks/flutter-dev/EXAMPLES.md
is excluded by!docs/sdks/**
📒 Files selected for processing (1)
CONTRIBUTING.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md
[style] ~36-~36: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...hout review. ###
(EN_WEAK_ADJECTIVE)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: scan
🔇 Additional comments (1)
CONTRIBUTING.md (1)
12-18
: Clear, action-oriented introduction looks good
The rewritten intro succinctly orients newcomers and links directly to curated issue filters—nice improvement in contributor onboarding.
What does this PR do?
This is the same PR as #10144 but in here I'm merging it with 1.7.x branch
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist