Skip to content

chore: Remove sortedcollections and sortedcontainers packages #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

chore: Remove sortedcollections and sortedcontainers packages #1362

merged 2 commits into from
Aug 19, 2025

Conversation

vdusek
Copy link
Collaborator

@vdusek vdusek commented Aug 19, 2025 •
edited
Loading

Description

  • Remove sortedcollections and sortedcontainers packages from dependencies.
  • Replace the sorted list in the Snapshotter with a custom class.

Issues

Testing

  • One new test for the SortedSnapshotList plus the current test set covers the changes.

Checklist

  • CI passed

@vdusek vdusek added this to the 121st sprint - Tooling team milestone Aug 19, 2025
@vdusek vdusek requested a review from Pijukatel August 19, 2025 08:08
@vdusek vdusek self-assigned this Aug 19, 2025
@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 19, 2025
@vdusek vdusek changed the title chore: Remove sortedcollections and sortedcontainers pkgs chore: Remove sortedcollections and sortedcontainers packages Aug 19, 2025
Pijukatel
Pijukatel reviewed Aug 19, 2025
View reviewed changes
@vdusek vdusek force-pushed the rm-sorted-collections-containers branch from 3e975a3 to 72dddec Compare August 19, 2025 08:59
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Aug 19, 2025
@vdusek vdusek force-pushed the rm-sorted-collections-containers branch from 72dddec to 3dedc17 Compare August 19, 2025 09:01
janbuchar
janbuchar approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@vdusek vdusek force-pushed the rm-sorted-collections-containers branch from 3dedc17 to dd90b34 Compare August 19, 2025 09:10
@vdusek vdusek merged commit f332408 into master Aug 19, 2025
35 of 36 checks passed
@vdusek vdusek deleted the rm-sorted-collections-containers branch August 19, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pijukatel Pijukatel Pijukatel left review comments

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
121st sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

Optimize package footprint by removing unnecessary deps
3 participants
@vdusek @janbuchar @Pijukatel