Skip to content

[ISSUES #281 #274 #285 #287] Speeds up topic and consumer queries, adds caching, and fixes delay/dead-letter topic mix-up #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2025

Conversation

Crazylychee
Copy link
Contributor

@Crazylychee Crazylychee commented Apr 10, 2025

What is the purpose of the change

#281 #274 #285 #287

Brief changelog

The existing code for querying topics and consumers in the old version has a lot of redundant operations and repeated queries, which can easily lead to timeouts and errors when dealing with large data volumes. This PR mainly optimizes the speed of querying topics and consumers. Additionally, due to the longer time required to query consumers, caching is used to optimize the speed of the second query, and an option to refresh individual entries is provided. It also resolves the issue of confusion between delay topics and dead-letter topics.

Verifying this change

issues287

image
image

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
    /

@Crazylychee Crazylychee changed the title [ISSUES #281 #274 #285] Speeds up topic and consumer queries, adds caching, and fixes delay/dead-letter topic mix-up [ISSUES #281 #274 #285 #287] Speeds up topic and consumer queries, adds caching, and fixes delay/dead-letter topic mix-up Apr 13, 2025
@Crazylychee Crazylychee marked this pull request as ready for review April 13, 2025 09:32
@RongtongJin RongtongJin merged commit bbabd1c into apache:master Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants