Skip to content

Conversation

colinbellino
Copy link
Contributor

No description provided.

enginoid added a commit that referenced this pull request Jun 29, 2013
Add bower support with component.json
@enginoid enginoid merged commit 37a9492 into angular-oauth:master Jun 29, 2013
@enginoid
Copy link
Contributor

@colin-bellino Thanks a lot for the contribution!

@vperron I think that's a good idea. I'm sure if people have bower versions that don't support bower.json, it's easy enough to upgrade without problems since it's just a system utility.

@vperron
Copy link

vperron commented Jun 29, 2013

I am also not really comfortable with the dependency on angular > 1.1.4, which makes it unusable with any stable angular version (those are in 1.0.x)

I tested it with 1.0.6 and it works like a charm. It seems that in the original code as well (oauth2callback.html for instance), the dependency is on 1.1.4... Can't we lower that ?

@colinbellino
Copy link
Contributor Author

You are right it should be bower.json instead of component.json, i guess i will make another pull request ;)

When adding the dependency on angular i took the version in the demo.html since i am not yet an expert on angular it was the "safe" choice for me. Since you tested it, i'm sure we can lower that to 1.0.6.

@colinbellino
Copy link
Contributor Author

@Enginous Thank you for merging it btw :o

@vperron
Copy link

vperron commented Jun 29, 2013

@colin-bellino Well I did a PR on my own as well, fixing also some other places ! See #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants