perf(forms): enable tree shaking of unused errors and properties #63298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d692392 to
e604ea6
Compare
e604ea6 to
5eb9f15
Compare
mmalerba
approved these changes
Aug 21, 2025
905e9b5 to
64242b3
Compare
The `ValidationError` and `AggregateProperty` classes used static factory methods to create instances. This pattern created a hard dependency from the base classes to all of their subclasses and variations. As a result, any application importing even a single validator (e.g., required) or property would inadvertently pull in the code for all other validators and properties, preventing effective tree-shaking and increasing bundle size. This refactoring removes the static factory methods and replaces them with standalone, exported functions or properties. This decouples the individual validators and properties, allowing bundlers to properly perform dead code elimination.
64242b3 to
cb3943e
Compare
mmalerba
approved these changes
Aug 21, 2025
197b393
into
angular:prototype/signal-forms
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ValidationErrorandAggregatePropertyclasses used static factory methods to create instances. This pattern created a hard dependency from the base classes to all of their subclasses and variations.As a result, any application importing even a single validator (e.g., required) or property would inadvertently pull in the code for all other validators and properties, preventing effective tree-shaking and increasing bundle size.
This refactoring removes the static factory methods and replaces them with standalone, exported functions or properties. This decouples the individual validators and properties, allowing bundlers to properly perform dead code elimination.