Skip to content

refactor(http): rework the HttpEvent union to improve narrowing. #63267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(http): rework the HttpEvent union to improve narrowing. #63267

wants to merge 1 commit into from
+18 −3

Conversation

JeanMeche
Copy link
Member

Prior to this change, HttpProgressEvent could not be narrowed to HttpDownloadProgressEvent or HttpUploadProgressEvent

@pullapprove pullapprove bot requested a review from kirjs August 20, 2025 08:59
@JeanMeche JeanMeche added the action: global presubmit The PR is in need of a google3 global presubmit label Aug 20, 2025
@angular-robot angular-robot bot added the area: common/http Issues related to HTTP and HTTP Client label Aug 20, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 20, 2025
JoostK
JoostK reviewed Aug 20, 2025
View reviewed changes
@JeanMeche JeanMeche force-pushed the http-event-narrowing branch from 31893bc to 4d2376c Compare August 20, 2025 11:12
@JeanMeche
refactor(http): rework the HttpEvent union to improve narrowing.
4115855 
Prior to this change, `HttpProgressEvent` could not be narrowed to `HttpDownloadProgressEvent` or `HttpUploadProgressEvent`
@JeanMeche JeanMeche force-pushed the http-event-narrowing branch from 4d2376c to 4115855 Compare August 20, 2025 12:13
@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label Aug 20, 2025
@JeanMeche JeanMeche linked an issue Aug 20, 2025 that may be closed by this pull request
Can't access partialText on an HttpProgressEvent unless I cast it first #63254
Open
@JeanMeche
Copy link
Member Author

TGP is "green"

@JeanMeche JeanMeche removed the action: global presubmit The PR is in need of a google3 global presubmit label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoostK JoostK JoostK left review comments

@kirjs kirjs Awaiting requested review from kirjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Can't access partialText on an HttpProgressEvent unless I cast it first
2 participants
@JeanMeche @JoostK