refactor(animations): remove dependency on @angular/common
#63248
+5
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00ce1d8 to
3b13096
Compare
3b13096 to
a9e7fd9
Compare
|
Deployed adev-preview for a8d701d to: https://ng-dev-previews-fw--pr-angular-angular-63248-adev-prev-ttun7f7r.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
`DOCUMENT` was move to `@angular/core`, so we don't need to depend on common anymore.
a9e7fd9 to
a8d701d
Compare
|
I build locally the integration project locally, could find any major difference to explain the size increase. It must be pre-exisiting. |
thePunderWoman
approved these changes
Aug 20, 2025
josephperrott
approved these changes
Aug 21, 2025
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "dist/main.js": 86540, | |||
| "dist/main.js": 97227, | |||
There was a problem hiding this comment.
This seems extremely counter intuitive for a change where we are removing a dependency? Is this correct?
There was a problem hiding this comment.
We spent some time looking at it, but it doesn't appear to be coming from this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCUMENTwas move to@angular/core, so we don't need to depend on common anymore.