docs(docs-infra): mark properties as readonly if they shouldn't change #63200
+21
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
Aug 17, 2025
adev/shared-docs/components/search-dialog/search-dialog.component.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Aug 17, 2025
...c/app/features/references/api-reference-details-page/api-reference-details-page.component.ts
Outdated
Show resolved
Hide resolved
alan-agius4
approved these changes
Aug 18, 2025
1c0ac76 to
62ba209
Compare
JeanMeche
reviewed
Aug 18, 2025
adev/shared-docs/components/top-level-banner/top-level-banner.component.ts
Outdated
Show resolved
Hide resolved
JeanMeche
approved these changes
Aug 18, 2025
|
We'll need you to squash the changes again as the latest commit is not a fixup. Thank you. |
8236533 to
49555ca
Compare
JeanMeche
reviewed
Aug 22, 2025
| readonly onClose = output(); | ||
| readonly dialog = viewChild.required<ElementRef<HTMLDialogElement>>('searchDialog'); | ||
| readonly items = viewChildren(SearchItem); | ||
| readonly textField = viewChild(TextField); |
There was a problem hiding this comment.
lets do the same with the other props in the file
There was a problem hiding this comment.
I believe it’s already implemented. Can you specify which files are missing?
There was a problem hiding this comment.
l71-73
searchQuery = this.search.searchQuery;
resultsResource = this.search.resultsResource;
searchResults = this.search.searchResults;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information