-
Notifications
You must be signed in to change notification settings - Fork 26.5k
docs: Add docs SSR RESPONSE_INIT usage #63195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
979b2aa
to
2750f52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few concerns about adding this to the documentation.
- Directly setting headers in the route configuration is the recommended method.
- The
REQUEST_INIT
isn't an Angular concept and is already well-documented on MDN. - There have been no user requests or issues raised about adding more documentation for this.
I understand that configuring headers through the router is the recommended approach. However, there are scenarios—such as managing cookies on the client side—where dynamic header manipulation within the application becomes necessary. For example, synchronizing cookies between the server and client or updating them based on application logic is a common requirement. Therefore, having guidance on how to handle cookies dynamically within Angular could be valuable for developers facing these use cases. In my case in the referer link in MDN don't found information direct how set header cookie But i understand that Set Cookie is part of the standard HTTP ( https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie ) , and work well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little minor tweak, but this otherwise looks fine aside from @alan-agius4's concerns.
2750f52
to
eea2d41
Compare
Add docs SSR RESPONSE_INIT usage
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information