Skip to content

docs: Add docs SSR RESPONSE_INIT usage #63195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Aug 16, 2025

Add docs SSR RESPONSE_INIT usage

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from bencodezen August 16, 2025 03:50
@angular-robot angular-robot bot added the area: docs Related to the documentation label Aug 16, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 16, 2025
@JeanMeche JeanMeche requested review from alan-agius4 and removed request for bencodezen August 16, 2025 17:40
@SkyZeroZx SkyZeroZx force-pushed the add-docs-ssr-cookies branch 3 times, most recently from 979b2aa to 2750f52 Compare August 17, 2025 17:58
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few concerns about adding this to the documentation.

  • Directly setting headers in the route configuration is the recommended method.
  • The REQUEST_INIT isn't an Angular concept and is already well-documented on MDN.
  • There have been no user requests or issues raised about adding more documentation for this.

@SkyZeroZx
Copy link
Contributor Author

I have a few concerns about adding this to the documentation.

  • Directly setting headers in the route configuration is the recommended method.
  • The REQUEST_INIT isn't an Angular concept and is already well-documented on MDN.
  • There have been no user requests or issues raised about adding more documentation for this.

I understand that configuring headers through the router is the recommended approach. However, there are scenarios—such as managing cookies on the client side—where dynamic header manipulation within the application becomes necessary. For example, synchronizing cookies between the server and client or updating them based on application logic is a common requirement. Therefore, having guidance on how to handle cookies dynamically within Angular could be valuable for developers facing these use cases.

In my case in the referer link in MDN don't found information direct how set header cookie
https://developer.mozilla.org/en-US/docs/Web/API/Response/Response

But i understand that Set Cookie is part of the standard HTTP ( https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie ) , and work well

Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little minor tweak, but this otherwise looks fine aside from @alan-agius4's concerns.

@SkyZeroZx SkyZeroZx force-pushed the add-docs-ssr-cookies branch from 2750f52 to eea2d41 Compare August 20, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants