Skip to content

Refactor/docs viewer #63167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor/docs viewer #63167

wants to merge 1 commit into from
+19 −6

Conversation

akib1997
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No tooltip on example code block

Issue Number: N/A

What is the new behavior?

a tooltip on hover: "Copy code"
a Copied message after clicking

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from AndrewKushnir August 14, 2025 20:44
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Aug 14, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 14, 2025
@JeanMeche
Copy link
Member

git commit --fixup HEAD

There seems to be an issue with your fixup, you should probably squash everything.

@JeanMeche JeanMeche added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews adev: preview labels Aug 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

Deployed adev-preview for 564cc8c to: https://ng-dev-previews-fw--pr-angular-angular-63167-adev-prev-gk6re295.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@akib1997 akib1997 force-pushed the refactor/docs-viewer branch from 1af56fd to dff7c20 Compare August 16, 2025 19:19
@JeanMeche
Copy link
Member

We still have an issue with your commits that don't follow the commit message guidelines. Could you please squash your changes.

@akib1997 akib1997 force-pushed the refactor/docs-viewer branch 2 times, most recently from f5d6fef to 564cc8c Compare August 18, 2025 15:28
@akib1997 akib1997 requested a review from JeanMeche August 22, 2025 23:45
@JeanMeche
Copy link
Member

You'll need to rebase this PR, there is a conflict on a file.

@akib1997 akib1997 force-pushed the refactor/docs-viewer branch from 564cc8c to 235ba40 Compare August 24, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

@JeanMeche JeanMeche Awaiting requested review from JeanMeche

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@akib1997 @JeanMeche