-
Notifications
You must be signed in to change notification settings - Fork 26.5k
feat(docs-infra): add file explorer tree to the playground editor #63113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(docs-infra): add file explorer tree to the playground editor #63113
Conversation
replaced tabs with mat-tree to support nesting files under folders in the future. resolves angular#52659 issue
Deployed adev-preview for 52d0484 to: https://ng-dev-previews-fw--pr-angular-angular-63113-adev-prev-qe6l9v9w.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
use class binding instead
Hi everyone, Any updates ? is my general direction correct? should I proceed to implement the tests ? or should I wait for the review ? |
Hi @ali-toghiani! Thanks for this initiative. Currently, the "open in..." menu is broken, can you please take a look? |
Hi Mark, Thanks for letting me know, Absolutely, I'm on it, I'll push the fix ASAP |
Hi @MarkTechson The Issue with the "Open in ..." dropdown style has been fixed |
replaced tabs with mat-tree to support nesting files under folders in the future.
resolves #52659 issue
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
currently Playgound uses tabs to show different files
Issue Number: #52659
What is the new behavior?
added a sidebar called the activity bar which includes a folder icon, when clicked, expands a the file explorer section.
the file explorer includes a header that allows creating new files, and the list of files which are created using the mat-tree component. the reason that the mat-tree component is choosen, is to create the support for future to to add folder creation capabilities.
Does this PR introduce a breaking change?
Other information