Review pass & fixup of the control directive & related code #63068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
commented
Aug 9, 2025
35f39b4 to
b589dee
Compare
leonsenft
requested changes
Aug 11, 2025
b589dee to
a7717bd
Compare
leonsenft
requested changes
Aug 18, 2025
8ac7f85 to
69a9b9f
Compare
|
re: TODOs - hoping Alex will have a chance to comment on some of them, if not I'll leave them in an add an item to our backlog |
Also notes a few properties in comments that we should consider supporting if possible
this allows cleaning up hacky test code to run it in node
Co-authored-by: Leon Senft <leonsenft@users.noreply.github.com>
69a9b9f to
539e3b9
Compare
539e3b9 to
f4b717c
Compare
leonsenft
approved these changes
Aug 19, 2025
Comment on lines
+15
to
+17
| // TODO: `ValidationError` and `DisabledReason` are inherently tied to the signal forms system. | ||
| // They don't make sense when using a ccontrol separately from the forms system and setting the | ||
| // inputs individually. Givn that, should they still be part of this interface? |
There was a problem hiding this comment.
When in doubt, keep the API smaller? If they don't make sense maybe we leave it out unless there's a clear use case or requirement for them?
There was a problem hiding this comment.
I'm pretty sure we will want them in some form, but we may want to make the types more friendly to standalone use. I'll address the TODO in a followup after Alex has a chance to chime in
9866f91
into
angular:prototype/signal-forms
13 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.