fix(core): Fixed inject migration schematics for migrate destructured properties #62832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d978f3c to
ff3fcf4
Compare
|
Fixed lint |
JeanMeche
reviewed
Aug 20, 2025
packages/core/schematics/ng-generate/inject-migration/migration.ts
Outdated
Show resolved
Hide resolved
ff3fcf4 to
0dfe02b
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the inject migration schematic to correctly handle destructured properties in constructor parameters. The implementation introduces a ParameterMigrationContext to group related parameters, refactors the main migration function to handle different parameter kinds, and adds logic to correctly transform destructured properties into class properties with inject(). A new test case is also added to cover this scenario. The changes are well-structured and the fix appears correct. I have one minor suggestion to improve code clarity.
packages/core/schematics/ng-generate/inject-migration/migration.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Aug 22, 2025
packages/core/schematics/ng-generate/inject-migration/migration.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Aug 22, 2025
packages/core/schematics/ng-generate/inject-migration/migration.ts
Outdated
Show resolved
Hide resolved
0dfe02b to
7b38c50
Compare
|
@JeanMeche fixed lint and made the requested changes |
JeanMeche
reviewed
Aug 22, 2025
packages/core/schematics/ng-generate/inject-migration/migration.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Aug 22, 2025
… properties Fixes angular#62626 - Properties used with the destructor are also managed during migration.
7b38c50 to
3a970bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed inject migration schematics for migrate destructured properties
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #62626
What is the new behavior?
Fixed inject migration schematics for migrate destructured properties
Does this PR introduce a breaking change?