Skip to content

fix(elements): custom-element now handle input alias name #58317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(elements): custom-element now handle input alias name #58317

wants to merge 1 commit into from

Conversation

sheikalthaf
Copy link
Contributor

input alias option is not working and this PR fixed the issue

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #58302

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sheikalthaf
fix(elements): custom-element now handle input alias name
30590f5 
input alias option is not working and this PR fixed the issue
@sheikalthaf sheikalthaf marked this pull request as ready for review October 23, 2024 05:53
@pullapprove pullapprove bot requested a review from alxhub October 23, 2024 05:53
@angular-robot angular-robot bot added the area: elements Issues related to Angular Elements label Oct 23, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 23, 2024
@thePunderWoman thePunderWoman marked this pull request as draft May 21, 2025 15:28
@thePunderWoman thePunderWoman removed the request for review from alxhub June 3, 2025 11:01
@thePunderWoman thePunderWoman requested a review from crisbeto June 27, 2025 13:44
@thePunderWoman thePunderWoman marked this pull request as ready for review June 27, 2025 13:44
@thePunderWoman
Copy link
Contributor

@sheikalthaf This looks to have legitimate broken tests. Want to take a look?

@JeanMeche JeanMeche marked this pull request as draft June 27, 2025 14:45
@JeanMeche JeanMeche modified the milestones: Backlog, v21 Candidate Jun 27, 2025
@JeanMeche JeanMeche marked this pull request as ready for review August 21, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: elements Issues related to Angular Elements breaking changes
Projects
None yet
Milestone
v21 Candidate
Development

Successfully merging this pull request may close these issues.
3 participants
@sheikalthaf @thePunderWoman @JeanMeche