Skip to content
This repository was archived by the owner on Jul 6, 2025. It is now read-only.

fix: avoid setting userAgent when it's already set #473

Merged
merged 1 commit into from
May 19, 2022
Merged

fix: avoid setting userAgent when it's already set #473

merged 1 commit into from
May 19, 2022

Conversation

kt3k
Copy link
Contributor

@kt3k kt3k commented May 18, 2022

navigator.userAgent has become getter-only property at denoland/deno#14415, and we can't set it anymore. This PR avoids error with that

ije
ije approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ije ije merged commit bb011a2 into alephjs:main May 19, 2022
@kt3k kt3k deleted the fix/do-not-set-user-agent-when-already-set branch May 19, 2022 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ije ije ije approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @ije