Skip to content
This repository was archived by the owner on Jul 6, 2025. It is now read-only.

Await renderListener callback #393

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

TjeuKayim
Copy link
Contributor

@TjeuKayim TjeuKayim commented Sep 16, 2021

The callback is awaited in createSPAIndexHtml() but not in #renderPage()

@TjeuKayim TjeuKayim requested a review from ije as a code owner September 16, 2021 13:49
@TjeuKayim TjeuKayim marked this pull request as draft September 16, 2021 13:49
@TjeuKayim TjeuKayim marked this pull request as ready for review September 16, 2021 14:06
@ije
Copy link
Member

ije commented Sep 16, 2021

lgtm, thanks @TjeuKayim

@ije ije merged commit 68ae617 into alephjs:master Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants