As5600 #798
As5600 #798
Conversation
| @brief Destructor for an AS5600 sensor. | ||
| */ | ||
| /*******************************************************************************/ | ||
| ~WipperSnapper_I2C_Driver_AS5600() { delete _as5600; } |
There was a problem hiding this comment.
never called, check reinit of same sensor without reboot!
Otherwise if issues then check object in begin and delete if necessary
There was a problem hiding this comment.
Before deleting like this, check that the object does not refer to a nullptr otherwise it'll crash.
Something like this would check if the ptr == nullptr
if (_as5600)
delete _as5600;
|
Note to self - Do not merge without testing reinitialising the as5600 |
| @brief Destructor for an AS5600 sensor. | ||
| */ | ||
| /*******************************************************************************/ | ||
| ~WipperSnapper_I2C_Driver_AS5600() { delete _as5600; } |
There was a problem hiding this comment.
Before deleting like this, check that the object does not refer to a nullptr otherwise it'll crash.
Something like this would check if the ptr == nullptr
if (_as5600)
delete _as5600;
| */ | ||
| /*******************************************************************************/ | ||
| bool getEventRaw(sensors_event_t *rawEvent) { | ||
| ulong start = millis(); |
|
As mentioned in the MLX pull request, I believe (not verified 100%) the destructors are not being called, due to the |
Adds the magnetic angle sensor.
Worth noting the device zeros on reset/init.
Not sure my angular calculation from the "scaled" value correctly gives 0-359 which I think is what's expected.
Also didn't have a great magnet for testing, but did see rotation, and returning to approximate expected angle