Remove Tabs component #8762
Remove Tabs component #8762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8762 +/- ##
==========================================
- Coverage 99.11% 99.08% -0.04%
==========================================
Files 141 139 -2
Lines 4074 4043 -31
==========================================
- Hits 4038 4006 -32
- Misses 36 37 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The intention was to always remove this component as part of v4. The last component that is not directly used by ActiveAdmin is Panel which will remain as is with no other enhancements. In another major release we may remove Panel. The objective is for users to own their own components, whether directly or from another third party library. This also frees up the global builder method namespace in Arbre for tabs without conflict.
e9ef911 to
3b9dddb
Compare
|
@javierjulio have the mission or goal of activeadmin changed? I have always seen AA being an easy way to create crud like admin pages (hence the name) with a lot of flexibility for those admin "needs". Like a dashboard for the frontpage, or resource overviews with sidebars and tabs etc. Is that not the goal anymore? With more stuff moving to "bring your own". |
|
@henrikbjorn I don’t think so but other things have changed and improved since this library was created 15 years ago. There are better alternatives than what we can provide or should focus on. I think the Arbre builder namespace should be open for your own components and even for some HTML elements that were broken by AA like header and footer. That has been my goal with v4. |
Then I don't get the removal of those instead of finding a way to introduce override of those components etc. To add tabs into ActiveAdmin it now requires use to write a custom component, stimulus controller etc. for it (I assume)? |
|
@henrikbjorn that is correct. There are CSS only approaches too. This was always the intention with v4 as there are better alternatives than what was available 15 years ago. Sorry, that won’t change here. Thank you. |
|
if anyone has an alternative that is convenient to use, i'd be interested ... |
To ActiveAdmin or Tabs ? |
|
Tabs 😅 We use them heavily. For now, just pasting the component back in, with inlined tailwind classes like so, works fine. I guess it would only break if the surrounding styles were changed significantly or flowbite was removed, neither of which seem super likely? |
The intention was always to remove the Tabs component in v4. With this removal, that means the last component that is not directly used by ActiveAdmin is Panel which will remain as is with no other enhancements. In another major release we may remove Panel. The objective is for users to own their own components, whether directly or from another third party library and to free up the name from the Arbre namespace so it can be used without conflict.