Skip to content

Add typos workflow #8713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025
Merged

Add typos workflow #8713

merged 3 commits into from
May 6, 2025

Conversation

javierjulio
Copy link
Member

This adds a workflow to run typos CLI using Reviewdog and includes a _typos.toml configuration to address false positives. The "succesfully_destroyed" typo is ignored here so the workflow will go green as the typo correction will be addressed in #8712.

@javierjulio javierjulio self-assigned this May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (36ac258) to head (6148680).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8713   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4076     4076           
=======================================
  Hits         4040     4040           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@javierjulio javierjulio merged commit 0ef1d6a into master May 6, 2025
31 checks passed
@javierjulio javierjulio deleted the typos-workflow branch May 6, 2025 14:42
@@ -15,7 +15,7 @@ ActiveAdmin.register Post do
csv do
column :title
column(:author) { |post| post.author.full_name }
column('bODY', humanize_name: false) # preserve case
column('body', humanize_name: false) # preserves case of column title
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javierjulio, this was a fair use of 'bODY'. The "typo" + the comment shows that you can customize the title the way you need. The new comment looks good, I'm just talking about leaving 'bODY' as an exception of the new flow.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgrunberg yes, I know but I was cheating because its all lowercase and by default will capitalize so I think that was sufficient. Let me look into another update to ignore this specific word in only this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants