Skip to content

Fix pagination truncate translation key #8678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Fix pagination truncate translation key #8678

merged 1 commit into from
Apr 5, 2025

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Apr 5, 2025 •
edited
Loading

  • Add the missing key to up-to-date language files
  • Fix I18n tasks configuration for unscoped kaminari keys, which are now removed

Ref: #8218

@tagliala tagliala force-pushed the bugfix/fix-truncate-string branch from bdf800b to f20bc91 Compare April 5, 2025 19:54
@tagliala tagliala marked this pull request as ready for review April 5, 2025 19:54
@tagliala
Fix pagination truncate translation key
3896581 
- Add the missing key to up-to-date language files
- Fix I18n tasks configuration for unscoped kaminari keys, which are now
  removed

Ref: #8218
@tagliala tagliala force-pushed the bugfix/fix-truncate-string branch from f20bc91 to 3896581 Compare April 5, 2025 19:54
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (e463498) to head (3896581).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8678   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4076     4076           
=======================================
  Hits         4040     4040           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

javierjulio
javierjulio approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit a8b1024 into master Apr 5, 2025
26 checks passed
@tagliala tagliala deleted the bugfix/fix-truncate-string branch April 5, 2025 20:35
@tagliala tagliala mentioned this pull request Apr 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
type bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tagliala @javierjulio