Skip to content

Backport Support title for id_column #8652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Backport Support title for id_column #8652

merged 1 commit into from
Mar 8, 2025

Conversation

mgrunberg
Copy link
Contributor

Backport #8641


I'm building the index page of a resource. I must display the resource id as the first column but with a different title than "Id".

Using I18n to affect id's human_attribute_name is not a valid solution because that's a global change. The only workaround is to write the full column myself.

This PR adds support to customize id_column title.

@mgrunberg mgrunberg force-pushed the backport-8641 branch 3 times, most recently from 174632e to df66dd4 Compare March 8, 2025 02:52
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3-0-stable@4042f2e). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             3-0-stable    #8652   +/-   ##
=============================================
  Coverage              ?   99.19%           
=============================================
  Files                 ?      194           
  Lines                 ?     4971           
  Branches              ?        0           
=============================================
  Hits                  ?     4931           
  Misses                ?       40           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mgrunberg mgrunberg merged commit 0a36dbe into 3-0-stable Mar 8, 2025
24 checks passed
@mgrunberg mgrunberg deleted the backport-8641 branch March 8, 2025 02:57
@mgrunberg mgrunberg changed the title Backport Support sortable argument in id_column Backport Support title for id_column Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant