Use safe navigation for pundit_default_policy
#8530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8530 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4076 4076
=======================================
Hits 4040 4040
Misses 36 36 ☔ View full report in Codecov by Sentry. |
91ecbe7 to
e18c341
Compare
javierjulio
approved these changes
Nov 2, 2024
Use the safe navigation operator (`&.`) to streamline the `pundit_default_policy` constantization check, removing the need for a redundant `&&`. This change is now possible as the codebase no longer requires Ruby 2.3 support, which did not yet support safe navigation. The previous implementation was added in commit c93f6f4 to ensure compatibility with older Ruby versions. Also add the safe navigation operator to a subsequent usage of `default_policy_class`
e18c341 to
774c7f4
Compare
tagliala
added a commit
that referenced
this pull request
Nov 2, 2024
Replace a logic `&&` with safe navigation operator now that Ruby < 2.3 support is not required anymore Ref: #8530
tagliala
added a commit
that referenced
this pull request
Nov 2, 2024
Replace a logic `&&` with safe navigation operator now that Ruby < 2.3
support is not required anymore
Benchmark (Ruby 3.3.5 x64 / M1 Pro):
```
Comparison (not `nil`):
&.: 18787752.0 i/s
&&: 17963968.8 i/s - 1.05x (± 0.00) slower
Comparison (`nil`):
&&: 21343215.5 i/s
&.: 20910008.5 i/s - 1.02x (± 0.00) slower
```
Ref: #8530
tagliala
added a commit
that referenced
this pull request
Nov 2, 2024
Replace a logic `&&` with safe navigation operator now that Ruby < 2.3
support is not required anymore
Benchmark (Ruby 3.3.5 x64 / M1 Pro):
```
Comparison (not `nil`):
&.: 18787752.0 i/s
&&: 17963968.8 i/s - 1.05x (± 0.00) slower
Comparison (`nil`):
&&: 21343215.5 i/s
&.: 20910008.5 i/s - 1.02x (± 0.00) slower
```
Ref: #8530
tagliala
added a commit
that referenced
this pull request
Nov 7, 2024
Replace a logic `&&` with safe navigation operator now that Ruby < 2.3
support is not required anymore
Benchmark (Ruby 3.3.5 x64 / M1 Pro):
```
Comparison (not `nil`):
&.: 18787752.0 i/s
&&: 17963968.8 i/s - 1.05x (± 0.00) slower
Comparison (`nil`):
&&: 21343215.5 i/s
&.: 20910008.5 i/s - 1.02x (± 0.00) slower
```
Ref: #8530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the safe navigation operator (
&.) to streamline thepundit_default_policyconstantization check, removing the need for aredundant
&&.This change is now possible as the codebase no longer requires Ruby 2.3
support, which did not yet support safe navigation.
The previous implementation was added in commit c93f6f4 to ensure
compatibility with older Ruby versions.