Skip to content

Test against Rails 8.0.0 #8500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

Test against Rails 8.0.0 #8500

merged 1 commit into from
Nov 27, 2024

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Oct 12, 2024 •
edited
Loading

javierjulio
javierjulio reviewed Oct 12, 2024
View reviewed changes
@tagliala tagliala force-pushed the chore/test-against-rails80 branch 2 times, most recently from 016bec2 to 0fe643c Compare October 12, 2024 17:45
@codecov Codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (048d97c) to head (c4f62e8).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8500   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4076     4076           
=======================================
  Hits         4040     4040           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala force-pushed the chore/test-against-rails80 branch 2 times, most recently from 64cc3ec to 562dddf Compare October 12, 2024 17:54
@tagliala tagliala force-pushed the chore/test-against-rails80 branch 2 times, most recently from 22378e2 to d5726e4 Compare October 23, 2024 12:41
@tagliala tagliala changed the title [WIP] Test against rails80 Test against Rails 8.0 Oct 23, 2024
@tagliala tagliala force-pushed the chore/test-against-rails80 branch from d5726e4 to 7f26459 Compare November 2, 2024 22:08
@tagliala tagliala changed the title Test against Rails 8.0 Test against Rails 8.0.0.rc2 Nov 2, 2024
@tagliala tagliala force-pushed the chore/test-against-rails80 branch from 7f26459 to 5db33e9 Compare November 8, 2024 08:09
@tagliala tagliala changed the title Test against Rails 8.0.0.rc2 Test against Rails 8.0.0 Nov 8, 2024
@tagliala tagliala changed the title Test against Rails 8.0.0 Test against Rails 8.0.0 (blocked upstream) Nov 8, 2024
@tagliala tagliala force-pushed the chore/test-against-rails80 branch from 5db33e9 to ee17441 Compare November 10, 2024 09:39
@tagliala
Copy link
Contributor Author 

-    cucumber-rails (3.0.0)
-      capybara (>= 3.11, < 4)
-      cucumber (>= 5, < 10)
-      railties (>= 5.2, < 8)
+    cucumber-rails (1.4.0)
+      capybara (>= 1.1.2)
+      cucumber (>= 1.2.0)
+      nokogiri (>= 1.5.0)
+      rails (>= 3.0.0)

@tagliala
Copy link
Contributor Author

tagliala commented Nov 10, 2024 •
edited
Loading

Cucumber Rails seems to be the last blocker. There are no other unexpected downgrades, and CI is green.

Is there an action to check for downgrades? 🤔

@javierjulio
Copy link
Member

Ok thank you. I’m not sure if there is.

@tagliala tagliala marked this pull request as ready for review November 27, 2024 09:52
@tagliala tagliala force-pushed the chore/test-against-rails80 branch from ec37b5e to ef2aca6 Compare November 27, 2024 09:52
@tagliala tagliala force-pushed the chore/test-against-rails80 branch from ef2aca6 to c4f62e8 Compare November 27, 2024 09:53
@tagliala tagliala changed the title Test against Rails 8.0.0 (blocked upstream) Test against Rails 8.0.0 Nov 27, 2024
@tagliala tagliala requested a review from javierjulio November 27, 2024 10:06
javierjulio
javierjulio approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 9b0ca81 into master Nov 27, 2024
25 checks passed
@tagliala tagliala deleted the chore/test-against-rails80 branch November 27, 2024 15:22
@mgrunberg mgrunberg mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tagliala @javierjulio