Prefer require_relative for internal requires
#8482
Conversation
89c031e to
142812c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8482 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4069 4069
=======================================
Hits 4033 4033
Misses 36 36 ☔ View full report in Codecov by Sentry. |
|
@javierjulio do you want to take a look too? |
`require_relative` is preferred over `require` for files within the same project because it uses paths relative to the current file, making code more portable and less dependent on the load path. This change updates internal requires to use `require_relative` for consistency, performance, and improved portability. Ref: - activeadmin/arbre#622 - activeadmin/inherited_resources#939
142812c to
a213979
Compare
|
@deivid-rodriguez apparently this can be considered a breaking change (which is fine in a beta version) because of this side effect: varvet/pundit#831 (comment) I'm a little bit concerned about Any thoughts? I'm incline to make this change anyway and release in a patch, but at this point I would add a changelog entry |
|
I think as long as our release policy permits small enhancements like this in a patch release, then it's fine. I mean, it could make achieving certain things in development a bit harder, but should not be breaking any expected production usage of the gems, so seems fine to me. |
require_relativeis preferred overrequirefor files within the same project because it uses paths relative to the current file, making code more portable and less dependent on the load path.This change updates internal requires to use
require_relativefor consistency, performance, and improved portability.Ref:
require_relativefor internal requires arbre#622