Skip to content

Prepare 4.0.0.beta12 release #8478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tagliala
Copy link
Contributor

No description provided.

@tagliala tagliala force-pushed the chore/prep-release-4_0_0_beta12 branch from 8e3d8e4 to 8d7821f Compare September 15, 2024 17:13
@tagliala
Copy link
Contributor Author

I did this manually, is there a script?

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (8669d01) to head (8d7821f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8478   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4069     4069           
=======================================
  Hits         4033     4033           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio
Copy link
Member

@tagliala yes, there is a bin/prep-release <version> command but looks like you did the same changes already, including the Upgrading docs. You could try the script on a new branch and compare to your changes here to be sure it's the same but looks good. Thank you.

@tagliala
Copy link
Contributor Author

Yes, it is identical (except for the manual updates to upgrading guide)

Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 5eb77dc into activeadmin:master Sep 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants